Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bird: minor updates #57016

Merged
merged 2 commits into from Mar 7, 2019
Merged

bird: minor updates #57016

merged 2 commits into from Mar 7, 2019

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented Mar 7, 2019

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • N/A macOS
    • other Linux distributions
  • N/A Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • (none exist) Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after): about +24k for 1.6.x and +110k for 2.0.x.
  • Assured whether relevant documentation is up to date (no relevant changes in NEWS)
  • Fits CONTRIBUTING.md.

/cc maintainer @fpletz.

@fpletz fpletz merged commit ebb8a07 into NixOS:master Mar 7, 2019
@vcunat vcunat deleted the p/bird branch March 7, 2019 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vcunat @fpletz @GrahamcOfBorg