Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plantuml: downgrade graphviz to 2.32 #56957

Merged
merged 1 commit into from Mar 8, 2019

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Mar 6, 2019

Motivation for this change

PlantUML discourages Graphviz 2.39+ due to rendering bugs: see http://plantuml.com/faq (heading: "Which version of Graphviz should I use ?")

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

PlantUML discourages Graphviz 2.39+ due to rendering bugs: see
http://plantuml.com/faq (heading: "Which version of Graphviz should I use ?")
@erictapen
Copy link
Member

erictapen commented Mar 6, 2019

@oxij is doing an effort atm to move package configurations from all-packages.nix into the package definitions itself (see e.g. #56088). Maybe it would be a better suited to put your change into pkgs/tools/misc/plantuml/default.nix?

@oxij
Copy link
Member

oxij commented Mar 6, 2019 via email

@infinisil infinisil merged commit e3e50a1 into NixOS:master Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants