Skip to content
This repository has been archived by the owner on Apr 12, 2021. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs-channels
base: 97464d087ec4
Choose a base ref
...
head repository: NixOS/nixpkgs-channels
compare: dc988c0bd667
Choose a head ref
  • 5 commits
  • 9 files changed
  • 5 contributors

Commits on Mar 7, 2019

  1. superTuxKart: fix broken build

    @aanderse
    aanderse committed Mar 7, 2019
    Copy the full SHA
    a593753 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #56995 from aanderse/super-tux-kart 

    superTuxKart: fix broken build
    @markuskowa
    markuskowa committed Mar 7, 2019
    Copy the full SHA
    b161cd9 View commit details
    Browse the repository at this point in the history

  3. yoda: fix sha hash of the tarball 

    Tarball was replaced upstream. The files are the same, changes are meta
only (appear to be timestamps).

(cherry picked from commit cf1de3c)
    @veprbl
    veprbl committed Mar 7, 2019
    Copy the full SHA
    a9d6158 View commit details
    Browse the repository at this point in the history

  4. Merge #57015: lua packages: fix some bugs 

    (cherry picked from commit 2dc7486)
In particular, lua*Packages.luuid now builds.
    @Mic92 @vcunat
    Mic92 authored and vcunat committed Mar 7, 2019
    Copy the full SHA
    8ad811b View commit details
    Browse the repository at this point in the history

  5. module system: revert "remove types.optionSet", just deprecate (#56857) 

    The explicit remove helped to uncover some hidden uses of `optionSet`
in NixOps. However it makes life harder for end-users of NixOps - it will
be impossible to deploy 19.03 systems with old NixOps, but there is no
new release of NixOps with `optionSet` fixes.

Also, "deprecation" process isn't well defined. Even that `optionSet` was
declared "deprecated" for many years, it was never announced. Hence, I
leave "deprecation" announce. Then, 3 releases after announce,
we can announce removal of this feature.

This type has to be removed, not `throw`-ed in runtime, because it makes
some perfectly fine code to fail. For example:
```
$ nix-instantiate --eval -E '(import <nixpkgs/lib>).types' --strict
trace: `types.list` is deprecated; use `types.listOf` instead
error: types.optionSet is deprecated; use types.submodule instead
(use '--show-trace' to show detailed location information)
```
    @danbst
    danbst committed Mar 7, 2019
    Copy the full SHA
    dc988c0 View commit details
    Browse the repository at this point in the history