Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cheat: 2.3.1 -> 2.5.1 #57045

Closed
wants to merge 1 commit into from
Closed

cheat: 2.3.1 -> 2.5.1 #57045

wants to merge 1 commit into from

Conversation

aakropotkin
Copy link
Contributor

Motivation for this change

I personally wanted the new version because of the new configurable options they have added. Tested on my system and it works like a charm.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aakropotkin
Updated to latest Version
5c38fdb 
I personally wanted the new version because of the new configurable options they have added. Tested on my system and it works like a charm.

Is there any reason that we don't link the default cheat sheets?
My assumption is that this is because they wouldn't be editable?
@aakropotkin aakropotkin changed the title Updated to latest Version Updated Cheat to latest Version Mar 7, 2019
@GrahamcOfBorg GrahamcOfBorg requested a review from Mic92 March 7, 2019 21:28
worldofpeace
worldofpeace suggested changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

a commit msg that would meet the contribution guidelines would be

cheat: 2.3.1 -> 2.5.1

@Mic92 Mic92 changed the title Updated Cheat to latest Version cheat: 2.3.1 -> 2.5.1 Mar 8, 2019
@Mic92
Copy link
Member

Mic92 commented Mar 8, 2019

Handled in #57064

@Mic92 Mic92 closed this Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace requested changes

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aakropotkin @Mic92 @worldofpeace @GrahamcOfBorg