netdata: lm-sensor support #57044
Merged
netdata: lm-sensor support #57044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Mar 8, 2019
| @@ -23,6 +23,11 @@ stdenv.mkDerivation rec{ | |||
| $out/libexec/netdata/plugins.d/apps.plugin.org | |||
| ''; | |||
|
|
|||
| preConfigure = '' | |||
| substituteInPlace collectors/python.d.plugin/python_modules/third_party/lm_sensors.py \ | |||
| --replace 'ctypes.util.find_library("sensors")' "\"${lm_sensors.out}/lib/libsensors.so\"" | |||
There was a problem hiding this comment.
To make it work on macOS as well:
Suggested change
| --replace 'ctypes.util.find_library("sensors")' "\"${lm_sensors.out}/lib/libsensors.so\"" | |
| --replace 'ctypes.util.find_library("sensors")' "\"${lm_sensors.out}/lib/libsensors.${stdenv.hostPlatform.extensions.sharedLibrary}\"" |
There was a problem hiding this comment.
done !
It seems that extensions.sharedLibrary is already prefixed with a dot
nyanloutre
force-pushed
the
netdata-sensors
branch
from
42295e2
to
df88536
Compare
|
@GrahamcOfBorg build netdata |
|
Oh, lm_sensors is not compatible with MacOS. Maybe I should put a conditional ? |
|
I would go without the conditional for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Netdata will not find the lm-sensor library without this patch
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)