Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f16147864621
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4901dc4e7414
Choose a head ref
  • 6 commits
  • 3 files changed
  • 2 contributors

Commits on Dec 3, 2018

  1. chromium: remove gtk2 from build inputs (gtk3 should be enough)

    @avnik
    avnik committed Dec 3, 2018
    Copy the full SHA
    a70ab23 View commit details

  2. chroimum: Improve jumbo reproducibility 

    A little patch to jumbo script, which should improve reproducibility
by sorting source files before merge.
    @avnik
    avnik committed Dec 3, 2018
    Copy the full SHA
    254a16c View commit details

  3. chromium: avoid timestamp build 

    Use $SOURCE_DATE_EPOCH instead
    @avnik
    avnik committed Dec 3, 2018
    Copy the full SHA
    7b49bd4 View commit details

  4. chromium: fail build, if SOURCE_DATE_EPOCH not set 

    Also fix spacing style to conform google style
    @avnik
    avnik committed Dec 3, 2018
    Copy the full SHA
    d0351ad View commit details

  5. chromium: rename "unwrapped" package to chromium-unwrapped

    @avnik
    avnik committed Dec 3, 2018
    Copy the full SHA
    9ae406c View commit details

Commits on Mar 7, 2019

  1. Merge commit '9ae406c0749bbc7373d7422edeaf6b1b6caa0dae' of github.com… 

    …:NixOS/nixpkgs into fix-chromium

fixes #49797
    @bendlas
    bendlas committed Mar 7, 2019
    Copy the full SHA
    4901dc4 View commit details
8 changes: 5 additions & 3 deletions pkgs/applications/networking/browsers/chromium/common.nix
View file
Original file line number Diff line number Diff line change
@@ -11,7 +11,7 @@
, nspr, systemd, kerberos
, utillinux, alsaLib
, bison, gperf
, glib, gtk2, gtk3, dbus-glib
, glib, gtk3, dbus-glib
, glibc
, libXScrnSaver, libXcursor, libXtst, libGLU_combined
, protobuf, speechd, libXdamage, cups
@@ -104,7 +104,7 @@ let
else result;

base = rec {
name = "${packageName}-${version}";
name = "${packageName}-unwrapped-${version}";
inherit (upstream-info) version;
inherit packageName buildType buildPath;

@@ -120,7 +120,7 @@ let
nspr nss systemd
utillinux alsaLib
bison gperf kerberos
glib gtk2 gtk3 dbus-glib
glib gtk3 dbus-glib
libXScrnSaver libXcursor libXtst libGLU_combined
pciutils protobuf speechd libXdamage at-spi2-core
] ++ optional gnomeKeyringSupport libgnome-keyring3
@@ -132,6 +132,8 @@ let
patches = optional enableWideVine ./patches/widevine.patch ++ [
./patches/nix_plugin_paths_68.patch
./patches/remove-webp-include-69.patch
./patches/jumbo-sorted.patch
./patches/no-build-timestamps.patch

# Unfortunately, chromium regularly breaks on major updates and
# then needs various patches backported in order to be compiled with GCC.
11 changes: 11 additions & 0 deletions pkgs/applications/networking/browsers/chromium/patches/jumbo-sorted.patch
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
--- chromium-70.0.3538.67/build/config/merge_for_jumbo.py.old 2018-10-25 19:15:54.578222230 +0300
+++ chromium-70.0.3538.67/build/config/merge_for_jumbo.py 2018-10-25 19:20:44.397613032 +0300
@@ -132,6 +132,8 @@
assert not inputs
continue

+ inputs.sort()
+ outputs.sort()
write_jumbo_files(inputs, outputs, written_input_set, written_output_set)

assert set(args.outputs) == written_output_set, "Did not fill all outputs"
17 changes: 17 additions & 0 deletions pkgs/applications/networking/browsers/chromium/patches/no-build-timestamps.patch
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
--- chromium-70.0.3538.67/build/compute_build_timestamp.py.orig 2018-11-02 16:00:34.368933077 +0200
+++ chromium-70.0.3538.67/build/compute_build_timestamp.py 2018-11-08 04:06:21.658105129 +0200
@@ -94,6 +94,14 @@
'build_type', help='The type of build', choices=('official', 'default'))
args = argument_parser.parse_args()

+ # I don't trust LASTCHANGE magic, and I definelly want something deterministic here
+ SOURCE_DATE_EPOCH = os.getenv("SOURCE_DATE_EPOCH", None)
+ if SOURCE_DATE_EPOCH is not None:
+ print SOURCE_DATE_EPOCH
+ return 0
+ else:
+ raise RuntimeError("SOURCE_DATE_EPOCH not set")
+
# The mtime of the revision in build/util/LASTCHANGE is stored in a file
# next to it. Read it, to get a deterministic time close to "now".
# That date is then modified as described at the top of the file so that