Skip to content

superTuxKart: fix broken build #56995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2019
Merged

superTuxKart: fix broken build #56995

merged 1 commit into from
Mar 7, 2019
+9 −1

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Mar 6, 2019

Motivation for this change

#56826

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@aanderse
Copy link
Member Author

aanderse commented Mar 6, 2019

@GrahamcOfBorg build superTuxKart

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 6, 2019
@Mic92
Copy link
Member

Mic92 commented Mar 7, 2019

Is master also affected by this?

@markuskowa
Copy link
Member

Yes, master is also affected.

@markuskowa markuskowa merged commit b161cd9 into NixOS:release-19.03 Mar 7, 2019
@aanderse aanderse deleted the super-tux-kart branch March 7, 2019 18:37
@markuskowa
Copy link
Member

cherry picked into master 198b7ea

@aanderse
Copy link
Member Author

aanderse commented Mar 7, 2019

Thanks @markuskowa
@Mic92 Yes, and I also noted at least tome4 has the same error.

@teto
Copy link
Member

teto commented Apr 21, 2019

@aanderse feel like packaging the new v1.0 :D http://blog.supertuxkart.net/2019/04/supertuxkart-10-release.html

@aanderse
Copy link
Member Author

@teto sure, why not. #59973.

adrianpk added a commit to adrianpk/nixpkgs that referenced this pull request May 31, 2024
@adrianpk
Merge pull request NixOS#56995 from aanderse/super-tux-kart

Verified

This commit was signed with the committer’s verified signature.
infinisil Silvan Mosberger
GPG key ID: 9424360B4B85C9E7
Verified
Learn about vigilant mode
c18e6c7 
superTuxKart: fix broken build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aanderse @Mic92 @markuskowa @teto @GrahamcOfBorg