Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unifiStable: 5.10.17 -> 5.10.19 #56992

Merged
merged 1 commit into from Mar 7, 2019
Merged

unifiStable: 5.10.17 -> 5.10.19 #56992

merged 1 commit into from Mar 7, 2019

Conversation

bachp
Copy link
Member

@bachp bachp commented Mar 6, 2019

Motivation for this change

Update to latest stable version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/cc @erictapen as new maintainer

@erictapen
Copy link
Member

Hey @bachp, I'm not using unifi anymore and I don't know when it will it be the case again. Therefore I can't test your PR. Would you be interested in taking the maintainership?

also, @GrahamcOfBorg build unifiStable

@erictapen
Copy link
Member

Ofborg doesn't build it due to its unfree license. Anyway, LGTM.

@bachp
Copy link
Member Author

bachp commented Mar 7, 2019

I have it running and have observed no issues so far.

@erictapen I'm currently evaulating if running unifi via nixos is the way to go. So far it look stable. If I decide to go that route I will submit a PR replacing you as maintainer.

@xeji
Copy link
Contributor

xeji commented Mar 7, 2019

unfree package, build checked locally

@xeji xeji merged commit 87cb443 into NixOS:master Mar 7, 2019
@0x4A6F
Copy link
Member

0x4A6F commented Mar 7, 2019

@bacp I'm also running UniFi on NixOS, so you can also append me to maintainers.

@bachp bachp mentioned this pull request Mar 20, 2019
10 tasks
fpletz pushed a commit that referenced this pull request May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants