Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gnome 3.32 #57027

Merged
merged 172 commits into from Apr 5, 2019
Merged

Gnome 3.32 #57027

merged 172 commits into from Apr 5, 2019

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Mar 7, 2019 •
edited by jtojnar

The branch should be viable to use (I'm running it on my own system. Note that mutter is now build without checks which means extensions are more likely to crash the system :/

See https://hydra.nixos.org/eval/1509880?filter=x86_64-linux&compare=1509196&full=#tabs-now-fail for failures compared to appropriate trunk.

Closes: #56966

darwin

  • pango the new meson build fails the custom install script for the docs.
  • dconf fails tests

general:

  • trying to set a password in users-accounts panel of gnome-control-center is impossible because
    the path to the cracklib dictionary is non-existent (libpwquality -> cracklib) (error)

  • we should probably mark extensions that are known to be broken in 3.32 as broken. Mutter is now built without checks which makes it fairly easy for a wrong code path to crash the shell.

  • fix launching gnome-gweather from desktop file again as I broke it.

  • arc-theme fails to build, we should probably pick this patch

  • mate.libmatekbd fails

  • papirus-icon-theme fails due to a bad hash, not our fault, most of the deepin stuff is due to this

  • deepin.dd-api actually fails the build (this happened last upgrade too)

  • handbrake required harfbuzz (no longer propagated by pango)

  • pantheon.elementary-photos fails, same problem as shotwell with the gexiv vapi (upstream issue)

  • perl528Packages.Glib fails tests

  • mikutter fails due to pango gem, similar to last time with gio I believe

  • ntrack fails due to -Werror=pedantic

  • notary transient error, also fails on master with --check

  • uim fails to do some svg stuff, probably due librsvg upgrade

  • vips fails to find po/Makefile.in.in, which seems pretty strange, doesn't occur on master.

  • gnome-todo fails (upstream issue)

  • shotwell fails

  • gnome-builder is missing llvm-config

  • dconf fails a new integration tests (thought patchShebangs could take several arguments)

  • gtksourceview3 fails tests

  • haven't updated gnomeExtensions so most are probably broken

  • update dash-to-dock when they do a new release

  • I'm hitting this bug (telepathy-idle uses 100% cpu): https://gitlab.gnome.org/GNOME/polari/issues/74

  • rygel require packaging gupnp-1.2 and gssdp-1.2 and patching gupnp-igd if we're to continue having support in libnice (not sure if that's important tbh). According to release news rygel shouldn't be upgrade, so I'm assuming 0.37 is a dev branch not targeted for 3.32

  • see if any packages have libhandy suppert (eg. gnome-contacts ships its own, but we should probably use the system package).

  • I encountered a weird problem with vala-38 getting stuck in a loop parsing gir files, switching to 42 fixed the problem (libdbusmenu and packagekit), see a72b225. I wouldn't be surprised if we'll see it a few more times

  • Remove libsoup from gnome-contacts next rebase

@hedning hedning mentioned this pull request Mar 7, 2019
Closed
@jtojnar
Copy link
Contributor

jtojnar commented Mar 7, 2019

Regarding libsoup, it was previously propagated by libchamplain but meson port moved it to Requires.private` so I stopped propagating it 6b8c1d9 I added it to eds to fix elementary calendar 025960d

@worldofpeace
Copy link
Contributor

I should be able to get #54584 in here now

@worldofpeace
Copy link
Contributor

The failing test in question for gtksourceview* is

FAIL: test-language
===================

/Language/language-properties: **
GtkSourceView:ERROR:test-language.c:92:compare_strv: assertion failed (strv[i] == expected_strv[i]): ("test-full:string" == "test-full:keyword")
FAIL test-language (exit status: 134)

@hedning
Copy link
Contributor Author

hedning commented Mar 7, 2019 •
edited

Hmm, probably fixed by bumping shared-mime-info, only thing I can think of that would affect that: https://gitlab.gnome.org/GNOME/gtksourceview/blob/master/testsuite/test-language.c#L147

Edit: nope, didn't fix it

@worldofpeace worldofpeace mentioned this pull request Mar 8, 2019
Closed
10 tasks
@worldofpeace
Copy link
Contributor

see if any packages have libhandy suppert (eg. gnome-contacts ships its own, but we should probably use the system package).

Here's a nice little list that shows which applications have libhandy support

I don't like how they all have their own subprojects for libhandy, perhaps they should have an option to use the system package. Should be useful for distros in general.

@jtojnar
Copy link
Contributor

jtojnar commented Mar 8, 2019

They should use libhandy from system. At least g-c-c does:

https://gitlab.gnome.org/GNOME/gnome-control-center/blob/db2cc12c707abb420f820dbddd56c7b603306d4f/meson.build#L99

@worldofpeace
Copy link
Contributor

They should use libhandy from system. At least g-c-c does:

https://gitlab.gnome.org/GNOME/gnome-control-center/blob/db2cc12c707abb420f820dbddd56c7b603306d4f/meson.build#L99

Looks like gnome-contacts and epiphany does the same

So we don't have a problem.

@hedning
Copy link
Contributor Author

hedning commented Mar 8, 2019

Added system libhandy to gnome-contacts, g-c-c and epiphany.

@worldofpeace
Copy link
Contributor

Probably should just stick #57040 in here for testing

@hedning
Copy link
Contributor Author

hedning commented Mar 8, 2019 •
edited

Heads up: gnome-shell tends to crash a bunch due to this: #1027. We could pick !450, but I can't imagine the fix won't hit 3.32.

Edit: it's going in https://mail.gnome.org/archives/release-team/2019-March/msg00050.html

@worldofpeace @jtojnar
meld: 3.20.0 > 3.20.1
b22b5a2 
https://gitlab.gnome.org/GNOME/meld/tags/3.20.1
@worldofpeace @jtojnar
gnomeExtensions.battery-status: mark as broken
8f2e57d
@worldofpeace @jtojnar
gnomeExtensions.caffeine: 2018-09-25 -> 2019-04-02
974fefe
@worldofpeace @jtojnar
gnomeExtensions.mediaplayer: 3.5 -> 2019-03-21
98bf715 
* GNOME 3.32 support [0]

Also note this extension is being retired [1]

[0]: webmastak/gnome-shell-extensions-mediaplayer@c2483c1
[1]: webmastak/gnome-shell-extensions-mediaplayer#478
@worldofpeace @jtojnar
gnomeExtensions.no-title-bar: mark as broken
5d10529 
See: franglais125/no-title-bar#114
@worldofpeace @jtojnar
gnomeExtensions.timepp: 2019.03.17 -> 2019-03-30
76ccc74 
* GNOME 3.32 support [0]

[0]: zagortenay333/cronomix@28191b7
@worldofpeace @jtojnar
gnomeExtensions.icon-hider: mark as broken
294c1a6
@worldofpeace @jtojnar
gnomeExtensions.system-monitor: mark as broken
46874a7 
* Not yet compatable with GNOME 3.32 [0] [1]

[0]: paradoxxxzero/gnome-shell-system-monitor-applet#510
[1]: paradoxxxzero/gnome-shell-system-monitor-applet#511
@worldofpeace @jtojnar
gnomeExtensions.taskwhisperer: 11 -> 12
87d1ff4 
* has a proper Makefile
* resync patch

Changes: cinatic/taskwhisperer@v11...v12
@worldofpeace @jtojnar
pantheon.elementary-settings-daemon: 3.30.2 -> 3.32.0
a2c1f97 
- sync patches [0]
- clean up deps
- use gnome3.updateScript

[0]: https://git.launchpad.net/~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon/commit/?id=bab64774ef3a8f17b6fa29bb1d7aa1cb7c964341
@jtojnar
Copy link
Contributor

jtojnar commented Apr 5, 2019

Rebased onto staging, fixed conflicts and removed 81a87c5 and the reverted commit.

@hedning
Copy link
Contributor Author

hedning commented Apr 5, 2019

Thanks for all the work done everyone ❤️ Lets merge.

@hedning hedning merged commit 9d156a1 into staging Apr 5, 2019
This was referenced Apr 5, 2019
Closed
Open
Closed
Closed
@hedning
Copy link
Contributor Author

hedning commented Apr 6, 2019

There's some fallout on staging from setting vala = vala_0_44 on staging: https://hydra.nixos.org/eval/1512845?filter=gnome3&compare=1512812

In particular ibus fails to build: https://hydra.nixos.org/build/91681314

emojier.vala:1070.49-1071.42: error: Assignment: Cannot convert from `GLib.SList<string>' to `GLib.SList<weak string>?'
emojier.vala:1074.51-1074.61: error: The name `annotations' does not exist in the context of `IBusEmojier.show_candidate_panel'
            foreach (unowned string annotation in annotations) {
                                                  ^^^^^^^^^^^

Tried building ibus with vala-0.44.2, but that didn't fix it, so I'm guessing we should set 0.42 as a default for now? cc @worldofpeace

@jtojnar
Copy link
Contributor

jtojnar commented Apr 6, 2019

We should upgrade ibus to 1.5.20. Or if we want temporary fix, pin ibus to vala 0.42. I think the failures are a good think as they let us know when we have outdated packages :-D

@worldofpeace
Copy link
Contributor

I'll investigate the failures today as see what upgrades and fixes are needed.

@hedning
Copy link
Contributor Author

hedning commented Apr 6, 2019

gitg and vtg-ng needs 0.42. There's a pr for ibus #59009

@worldofpeace
Copy link
Contributor

gitg and vtg-ng needs 0.42. There's a pr for ibus #59009

Fixes on the way from me 👍

@jtojnar
Copy link
Contributor

jtojnar commented Apr 6, 2019

Weird, Arch uses the same version without any patches: https://www.archlinux.org/packages/extra/x86_64/gitg/

@worldofpeace
Copy link
Contributor

Weird, Arch uses the same version without any patches: https://www.archlinux.org/packages/extra/x86_64/gitg/

😄 They'll find out when they rebuild it

@jtojnar jtojnar deleted the gnome-3.32 branch April 17, 2019 23:40
@eljojo eljojo mentioned this pull request Aug 27, 2019
Closed
@jtojnar jtojnar mentioned this pull request Oct 2, 2019
Merged
20 tasks
@src-of-truth src-of-truth bot mentioned this pull request Oct 6, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@dtzWill dtzWill dtzWill left review comments

@worldofpeace worldofpeace worldofpeace left review comments

@FRidh FRidh Awaiting requested review from FRidh

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
2.status: work-in-progress 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 6.topic: pantheon The Pantheon desktop environment 6.topic: python 8.has: documentation 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@hedning @jtojnar @worldofpeace @dtzWill @romildo @matthewbauer @GrahamcOfBorg @jonafato