Skip to content

python2Packages.moinmoin: 1.9.9 -> 1.9.10 #56970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2019
Merged

python2Packages.moinmoin: 1.9.9 -> 1.9.10 #56970

merged 1 commit into from
Mar 8, 2019
+6 −6

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Mar 6, 2019

Motivation for this change

Changes:

https://github.com/moinwiki/moin-1.9/blob/1.9.10/docs/CHANGES#L13

This commit also replaces a ISO-8859-1 character in setup.cfg to fix the
build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@danieldk danieldk requested a review from FRidh as a code owner March 6, 2019 16:24
@xeji
Copy link
Contributor

xeji commented Mar 7, 2019

Looks like a duplicate of #48589, which got delayed for some reason. Please have a look at the other PR.
(btw, the package name moinmoin is missing in your commit and PR title).

@danieldk danieldk changed the title python2Packages: 1.9.9 -> 1.9.10 python2Packages.moinmoin: 1.9.9 -> 1.9.10 Mar 8, 2019
@danieldk
python2Packages.moinmoin: 1.9.9 -> 1.9.10

Verified

This commit was signed with the committer’s verified signature.
vcunat Vladimír Čunát
GPG key ID: E747DF1F9575A3AA
Verified
Learn about vigilant mode
421b153 
Changes:

https://github.com/moinwiki/moin-1.9/blob/1.9.10/docs/CHANGES#L13

This commit also replaces a ISO-8859-1 character in setup.cfg to fix the
build.
@danieldk
Copy link
Contributor Author

danieldk commented Mar 8, 2019

Whoops, fixed the commit. #48589 fails to build with current master, because setup.cfg contains an ISO-8859-1 character:

building
Traceback (most recent call last):
  File "nix_run_setup", line 8, in <module>
    exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\\r\\n', '\\n'), __file__, 'exec'))
  File "setup.py", line 355, in <module>
    setup(**setup_args)
  File "/nix/store/hdqimszjdb2kcl8c6gphxzdjpndjjax6-python-2.7.15/lib/python2.7/distutils/core.py", line 124, in setup
    dist.parse_config_files()
  File "/nix/store/ljrap1k8h1siz4ajhqp1zfz1g4j5s8ww-python2.7-bootstrapped-pip-19.0.3/lib/python2.7/site-packages/setuptools/dist.py", line 702, in parse_config_files
    self._parse_config_files(filenames=filenames)
  File "/nix/store/ljrap1k8h1siz4ajhqp1zfz1g4j5s8ww-python2.7-bootstrapped-pip-19.0.3/lib/python2.7/site-packages/setuptools/dist.py", line 599, in _parse_config_files
    (parser.read_file if six.PY3 else parser.readfp)(reader)
  File "/nix/store/hdqimszjdb2kcl8c6gphxzdjpndjjax6-python-2.7.15/lib/python2.7/ConfigParser.py", line 324, in readfp
    self._read(fp, filename)
  File "/nix/store/hdqimszjdb2kcl8c6gphxzdjpndjjax6-python-2.7.15/lib/python2.7/ConfigParser.py", line 479, in _read
    line = fp.readline()
  File "/nix/store/hdqimszjdb2kcl8c6gphxzdjpndjjax6-python-2.7.15/lib/python2.7/codecs.py", line 314, in decode
    (result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf8' codec can't decode byte 0xfc in position 57: invalid start byte
builder for '/nix/store/1mwrwz04zd84cq74lplig6pqpahkghk2-python2.7-moinmoin-1.9.10.drv' failed with exit code 1
error: build of '/nix/store/1mwrwz04zd84cq74lplig6pqpahkghk2-python2.7-moinmoin-1.9.10.drv' failed

@danieldk
Copy link
Contributor Author

danieldk commented Mar 8, 2019

Also fails on hydra for the current version of moin with the same error:

https://hydra.nixos.org/build/89721763/nixlog/1

@xeji
Copy link
Contributor

xeji commented Mar 8, 2019

@GrahamcOfBorg build python27Packages.moinmoin

@xeji xeji merged commit 449e7f9 into NixOS:master Mar 8, 2019
@xeji xeji mentioned this pull request Mar 8, 2019
Closed
9 tasks
xeji pushed a commit that referenced this pull request Mar 8, 2019
@xeji
python2Packages.moinmoin: 1.9.9 -> 1.9.10 (#56970)
6c34eaf 
Changes:

https://github.com/moinwiki/moin-1.9/blob/1.9.10/docs/CHANGES#L13

This commit also replaces a ISO-8859-1 character in setup.cfg to fix the
build.

(cherry picked from commit 449e7f9)
@xeji
Copy link
Contributor

xeji commented Mar 8, 2019

backported to 19.03 in 6c34eaf to fix the build. /cc #56826

@danieldk danieldk deleted the moin-1.9.10 branch March 9, 2019 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @xeji @GrahamcOfBorg