Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stepmania: switch to clangStdenv #56977

Merged
merged 1 commit into from Mar 8, 2019
Merged

stepmania: switch to clangStdenv #56977

merged 1 commit into from Mar 8, 2019

Conversation

kyren
Copy link
Contributor

@kyren kyren commented Mar 6, 2019 •
edited

Fixes #54227

Motivation for this change

Stepmania crashes on every NixOS computer I have tried without this patch, after this patch it works fine.

Like I said in #54227, I don't know if this is a mis-compilation or UB in stepmania that I can't find, and if it is mis-compilation I don't know what specific gcc bug it is.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kyren
stepmania: switch to clangStdenv
ff6e4b4 
Stepmania appears to be miscompiled with gcc, fixes #54227
@infinisil infinisil merged commit 36ee642 into NixOS:master Mar 8, 2019
@infinisil
Copy link
Member

Thanks!

Cherry-picked to 19.03 in 35845b0
Cherry-picked to 18.09 in 28e3039

@infinisil infinisil mentioned this pull request Mar 8, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kyren @infinisil @GrahamcOfBorg