Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.m2crypto: swig2 as nativeBuildInput so it can be invoked #57055

Merged
merged 1 commit into from Mar 8, 2019
Merged

pythonPackages.m2crypto: swig2 as nativeBuildInput so it can be invoked #57055

merged 1 commit into from Mar 8, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 7, 2019

Motivation for this change

Fixes #56993.

Assuming accepted, should be backported if needed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill requested a review from FRidh as a code owner March 7, 2019 23:40
@Mic92
Copy link
Member

Mic92 commented Mar 8, 2019

Is this a problem with cross compiling?

@dtzWill
Copy link
Member Author

dtzWill commented Mar 8, 2019

Only inputs in nativeBuildInputs end up on PATH, which has always been the idea but recently enforced for pythonPackages. Build with and without this change you'll notice a one-line difference (ha!) where it won't run swig before but does with this fix.

@Mic92
Copy link
Member

Mic92 commented Mar 8, 2019

I forgot that we already do this for python.

@Mic92 Mic92 merged commit afb4878 into NixOS:master Mar 8, 2019
@Mic92
Copy link
Member

Mic92 commented Mar 8, 2019

[detached HEAD 2832a89] pythonPackages.m2crypto: swig2 as nativeBuildInput so it can be invoked
Author: Will Dietz w@wdtz.org
Date: Thu Mar 7 17:37:39 2019 -0600
1 file changed, 1 insertion(+)

@dtzWill dtzWill deleted the fix/m2crypto-swig-libressl branch March 8, 2019 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @Mic92 @GrahamcOfBorg