Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filet: 0.1.1 -> 0.1.2 #57032

Merged
merged 1 commit into from Mar 7, 2019
Merged

filet: 0.1.1 -> 0.1.2 #57032

merged 1 commit into from Mar 7, 2019

Conversation

buffet
Copy link
Member

@buffet buffet commented Mar 7, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Mar 7, 2019

@GrahamcOfBorg build filet

xeji
xeji suggested changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please either fix the build on darwin or restrict platforms to platforms.linux.

@buffet
Copy link
Member Author

buffet commented Mar 7, 2019

Please either fix the build on darwin or restrict platforms to platforms.linux.

"Fixed". I just checked and #56938 is also broken, but has been merged.

@xeji
Copy link
Contributor

xeji commented Mar 7, 2019

Thanks.

... #56938 is also broken, but has been merged.

Well, we sometimes miss things 😄

Let's try again
@GrahamcOfBorg build filet

@xeji
Copy link
Contributor

xeji commented Mar 7, 2019

Still tries and fails to build on Darwin, unfortunately.

@buffet
Copy link
Member Author

buffet commented Mar 7, 2019

Sorry, that was on me again. NOW it's set to linux. Tripple checked.

@xeji
Copy link
Contributor

xeji commented Mar 7, 2019

@GrahamcOfBorg build filet

@xeji
Copy link
Contributor

xeji commented Mar 7, 2019

Thanks, looks good now.

@buffet
Copy link
Member Author

buffet commented Mar 7, 2019

Sorry for the inconviniences.

@xeji xeji merged commit 12153dc into NixOS:master Mar 7, 2019
@buffet buffet deleted the update-filet branch March 8, 2019 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@buffet @xeji @GrahamcOfBorg