Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: cf1de3c2df3d
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 60e8fcf0e56c
Choose a head ref
  • 1 commit
  • 4 files changed
  • 1 contributor

Commits on Mar 7, 2019

  1. module system: revert "remove types.optionSet", just deprecate (#56857)

    The explicit remove helped to uncover some hidden uses of `optionSet`
    in NixOps. However it makes life harder for end-users of NixOps - it will
    be impossible to deploy 19.03 systems with old NixOps, but there is no
    new release of NixOps with `optionSet` fixes.
    
    Also, "deprecation" process isn't well defined. Even that `optionSet` was
    declared "deprecated" for many years, it was never announced. Hence, I
    leave "deprecation" announce. Then, 3 releases after announce,
    we can announce removal of this feature.
    
    This type has to be removed, not `throw`-ed in runtime, because it makes
    some perfectly fine code to fail. For example:
    ```
    $ nix-instantiate --eval -E '(import <nixpkgs/lib>).types' --strict
    trace: `types.list` is deprecated; use `types.listOf` instead
    error: types.optionSet is deprecated; use types.submodule instead
    (use '--show-trace' to show detailed location information)
    ```
    danbst committed Mar 7, 2019
    Copy the full SHA
    60e8fcf View commit details
    Browse the repository at this point in the history