Skip to content

plasma: handle kbuildsycoca5 better #57037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2019
Merged

plasma: handle kbuildsycoca5 better #57037

merged 1 commit into from
Mar 12, 2019
+43 −3

Conversation

matthewbauer
Copy link
Member

@matthewbauer matthewbauer commented Mar 7, 2019 •
edited
Loading

The xdg-desktop-menu-dummy.menu file breaks kbuildsycoca5. Not sure why but it is a pretty
big failure if it exists. See issue #56176.

xdg-settings-desktop creates this file for some reason. I have no idea
why this is created though. But, it is used by Chromium and some other
software to set stuff up.

Also remove the ksycoca5 cache. Otherwise removed software hangs around in the cache forever.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@matthewbauer matthewbauer requested a review from ttuegel March 7, 2019 19:11
This was referenced Mar 7, 2019
Open
Closed
@matthewbauer
Copy link
Member Author

Hopefully we can backport it to 19.03.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: qt/kde 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Mar 7, 2019
@matthewbauer matthewbauer force-pushed the remove-xdg-desktop-menu-dummy branch from 928a9a0 to eb8709a Compare March 7, 2019 19:37
@matthewbauer matthewbauer changed the title plasma: remove xdg-desktop-menu-dummy.menu if it exists plasma: handle kbuildsyscoca5 better Mar 7, 2019
@matthewbauer matthewbauer changed the title plasma: handle kbuildsyscoca5 better plasma: handle kbuildsycoca5 better Mar 7, 2019
@matthewbauer matthewbauer force-pushed the remove-xdg-desktop-menu-dummy branch from c4695d3 to 0ec8fbd Compare March 7, 2019 20:09
@matthewbauer matthewbauer requested a review from infinisil as a code owner March 7, 2019 20:09
@matthewbauer
plasma: handle ksycoca5 better
393b359 
- Remove xdg-desktop-menu-dummy.menu kbuildsycoca5. Not sure why we
  need it but it is a pretty big failure if it exists.
  See issue NixOS#56176.

- plasma: clear ksycoca cache before building

  This is needed to pick up on software removed since the last cache
  update. Otherwise it hangs around as zombies forever (or until the
  cache is cleared).

- Add the above + the icon cache cleanup to plasmaSetup

  This will be run for the logged in user on each nixos-rebuild.
  Unfortunately this only works if you are managing software through
  nixos-rebuild (nix-env users need to run this manually, otherwise
  log out and log back in).
@matthewbauer matthewbauer force-pushed the remove-xdg-desktop-menu-dummy branch from 0ec8fbd to 393b359 Compare March 7, 2019 20:11
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Mar 7, 2019
@bkchr
Copy link
Contributor

bkchr commented Mar 7, 2019

Nice :) I always wanted to know who and why this file is created^^

@matthewbauer matthewbauer merged commit 7890494 into NixOS:master Mar 12, 2019
@Yarny0
Copy link
Contributor

Yarny0 commented Mar 14, 2019

I think there is a typo in line 247 of nixos/modules/services/x11/desktop-managers/plasma5.nix: a missing hash likely makes the script fail at this line. I didn't test it though.

@matthewbauer
Copy link
Member Author

Doh! Thanks - I had completely looked over that!

matthewbauer added a commit that referenced this pull request Mar 14, 2019
@matthewbauer
plasma5: fix typo from pr #57037
e67e588 
Thanks @Yarny0

(cherry picked from commit b703c4d)
aszlig pushed a commit to aszlig/nixpkgs that referenced this pull request Mar 14, 2019
@matthewbauer
plasma5: fix typo from pr NixOS#57037
b703c4d 
Thanks @Yarny0
@SuperSamus
Copy link
Contributor

#56176 is still open.
Also, #108240 should be closed too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel

@infinisil infinisil

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@matthewbauer @bkchr @Yarny0 @SuperSamus @GrahamcOfBorg