Fix #7334: Ship lost after crossing bridge due to path cache not being consumed while on final bridge end. #7335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot being consumed while on final bridge end.
PeterN
added
backport requested
michicc
approved these changes
Mar 8, 2019
TrueBrain
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7334.
An alternative method would be to not add the bridge tile to the path cache in the first place, however that requires checking every tile within the path to see if it's a bridge tile (not particularly slow but it adds up), whereas this method merely removes one entry from the cache when necessary.
This needs to be backported to 1.9.