Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

knot-dns: 2.7.6 -> 2.8.0 #56974

Merged
merged 1 commit into from Mar 9, 2019
Merged

knot-dns: 2.7.6 -> 2.8.0 #56974

merged 1 commit into from Mar 9, 2019

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented Mar 6, 2019 •
edited

https://gitlab.labs.nic.cz/knot/knot-dns/tags/v2.8.0
Some explanation for the patching is in this ML thread:
https://lists.nic.cz/pipermail/knot-dns-users/2019-March/001616.html

Motivation for this change

#56922 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • N/A Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of some binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after): +69k
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vcunat
Copy link
Member Author

vcunat commented Mar 6, 2019

I thought I'd wait with this, but it's related to the WIP for nixos knot service, so let me at least file this as PR early.

@vcunat vcunat mentioned this pull request Mar 6, 2019
Merged
10 tasks
@ryantm ryantm merged commit 08c589b into NixOS:master Mar 9, 2019
@vcunat vcunat deleted the p/knot-dns-2.8 branch March 9, 2019 07:43
vcunat pushed a commit that referenced this pull request Apr 9, 2019
@ryantm @vcunat
Merge pull request #56974 from vcunat/p/knot-dns-2.8
cd14d4c 
knot-dns: 2.7.6 -> 2.8.0
(cherry picked from commit 08c589b)
This had been tested in master for a month, without any complaints,
and 19.03 hasn't been officially released yet AFAIK.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vcunat @ryantm @GrahamcOfBorg