Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/bepasty: switch to python3Packages to match bepasty package #57006

Merged
merged 1 commit into from Mar 8, 2019
Merged

nixos/bepasty: switch to python3Packages to match bepasty package #57006

merged 1 commit into from Mar 8, 2019

Conversation

kyren
Copy link
Contributor

@kyren kyren commented Mar 7, 2019

I think the bepasty nixos service has been broken since c539c02, since
bepasty changed from using python2.7 to python3.7. This updates the
nixos module to refer to the matching python version.

Motivation for this change

Fixes the bepasty service, in 19.03 and unstable it currently just errors with ImportError: No module named bepasty.wsgi, since there is no bepasty module for python2.7 anymore.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kyren
nixos/bepasty: switch to python3Packages to match bepasty package
4bf1d8c 
I think the bepasty nixos service has been broken since c539c02, since
bepasty changed from using python2.7 to python3.7.  This updates the
nixos module to refer to the matching python version.
@kyren kyren requested a review from infinisil as a code owner March 7, 2019 03:31
@infinisil infinisil merged commit 0036842 into NixOS:master Mar 8, 2019
@kyren kyren deleted the bepasty-fix branch March 9, 2019 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kyren @infinisil @GrahamcOfBorg