Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure waagent: 2.0 -> 2.2.36 #56986

Closed
wants to merge 2 commits into from
Closed

azure waagent: 2.0 -> 2.2.36 #56986

wants to merge 2 commits into from
+13 −8

Conversation

thpham
Copy link
Member

@thpham thpham commented Mar 6, 2019

Motivation for this change

update the old Windows Azure Agent which is not anymore supported.

This is a WIP, I would appreciate any guidance how I could test locally that it is working as expected without having to go through the long process of creating the image.vhd, create a custom image and finally, boot and pray.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@thpham thpham requested a review from infinisil as a code owner March 6, 2019 21:00
@thpham thpham mentioned this pull request Mar 6, 2019
Closed
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 6, 2019
@khssnv khssnv mentioned this pull request Mar 7, 2019
Open
@thpham thpham changed the title [WIP] azure waagent: 2.0 -> 2.2.36 azure waagent: 2.0 -> 2.2.36 Mar 7, 2019
@thpham
Copy link
Member Author

thpham commented Mar 9, 2019

Hello @jbgi, This PR is inspired with what you started here. Did you had the chance to test it more ? or could you give me advice to test this ?

@infinisil
Copy link
Member

I just noticed, this azure-waagent package is not even defined in pkgs/top-level/all-packages.nix, so it doesn't get built by hydra and we can't tell the bot here to build it. Can you move it there so it's a normal package?

@infinisil infinisil added the 8.has: package (update) This PR updates a package to a newer version label Mar 30, 2019
@aanderse
Copy link
Member

@thpham are you able to address points mentioned above?

@stale
Copy link

stale bot commented Jun 2, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2020
SuperSandro2000
SuperSandro2000 requested changes Nov 28, 2020
View reviewed changes
nixos/modules/virtualisation/azure-agent.nix
Comment on lines +35 to +36
substituteInPlace config/66-azure-storage.rules \
--replace /bin/sh "${bash}/bin/sh"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use patchShebangs.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 28, 2020
@thpham thpham closed this Dec 21, 2020
@thpham thpham deleted the update-waagent2.2 branch December 21, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil

@SuperSandro2000 SuperSandro2000

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@thpham @infinisil @aanderse @SuperSandro2000 @GrahamcOfBorg