Have you tried building from source? There is a .travis.yml file at the root of their repo so it might be doable.

It's most likely doable, but I needed something quick to get started and decided to contribute it. Hopefully someone can improve it later, but I figured it might help other people who need to use this tool to generate Windows installers.

Is anything missing in this PR before it can be merged?

It's a bit strange that we are repackaging a ubuntu package. Looking at AUR [1] this doesn't seem to be such a complicated package. It does require a cross-compiled zlib though, which nixpkgs should be able to provide.

[1] https://aur.archlinux.org/packages/nsis/

Regarding cross compilation, this might help: https://matthewbauer.us/blog/beginners-guide-to-cross.html

Yeah, at the time I wrote this PR I was making my first steps in Nix, so did what would be quicker to get the result I needed. Since I saw that there were other packages which were repackaging dpkgs I thought it would be useful to contribute. I agree though that we should have a nsis package built from source, I just don't know if I'll have the time to dedicate to this. Feel free to close this PR in the mean time.

The other reason why this is still not merged might be that we don't have someone to test it. I'm not sure who to cc for this.

@veprbl I've updated the PR to build from source and used it in status-im/status-mobile#7506 with success.

@GrahamcOfBorg build nsis

cc @angerman