Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nsis: init at 3.04 #56990

Merged
merged 5 commits into from Mar 14, 2019
Merged

nsis: init at 3.04 #56990

merged 5 commits into from Mar 14, 2019

Conversation

pedropombeiro
Copy link
Contributor

@pedropombeiro pedropombeiro commented Mar 6, 2019

Motivation for this change

Add support for NSIS (Nullsoft Scriptable Install System) in Nix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@symphorien
Copy link
Member

Have you tried building from source? There is a .travis.yml file at the root of their repo so it might be doable.

@pedropombeiro
Copy link
Contributor Author

It's most likely doable, but I needed something quick to get started and decided to contribute it. Hopefully someone can improve it later, but I figured it might help other people who need to use this tool to generate Windows installers.

@pedropombeiro
Copy link
Contributor Author

Is anything missing in this PR before it can be merged?

@veprbl
Copy link
Member

veprbl commented Mar 13, 2019

It's a bit strange that we are repackaging a ubuntu package. Looking at AUR [1] this doesn't seem to be such a complicated package. It does require a cross-compiled zlib though, which nixpkgs should be able to provide.

[1] https://aur.archlinux.org/packages/nsis/

@veprbl
Copy link
Member

veprbl commented Mar 13, 2019

Regarding cross compilation, this might help: https://matthewbauer.us/blog/beginners-guide-to-cross.html

@pedropombeiro
Copy link
Contributor Author

pedropombeiro commented Mar 13, 2019

Yeah, at the time I wrote this PR I was making my first steps in Nix, so did what would be quicker to get the result I needed. Since I saw that there were other packages which were repackaging dpkgs I thought it would be useful to contribute. I agree though that we should have a nsis package built from source, I just don't know if I'll have the time to dedicate to this. Feel free to close this PR in the mean time.

@veprbl
Copy link
Member

veprbl commented Mar 13, 2019

The other reason why this is still not merged might be that we don't have someone to test it. I'm not sure who to cc for this.

@veprbl veprbl added the 6.topic: windows Running, or buiding, packages on Windows label Mar 13, 2019
@pedropombeiro pedropombeiro changed the title nsis: init at 2.50-1 nsis: init at 3.04 Mar 14, 2019
@pedropombeiro
Copy link
Contributor Author

@veprbl I've updated the PR to build from source and used it in status-im/status-mobile#7506 with success.

@veprbl
Copy link
Member

veprbl commented Mar 14, 2019

@GrahamcOfBorg build nsis

@veprbl veprbl merged commit 0b39750 into NixOS:master Mar 14, 2019
@veprbl
Copy link
Member

veprbl commented Mar 14, 2019

cc @angerman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants