Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opam: fix issue and upgrade #54566

Merged
merged 1 commit into from Jan 25, 2019
Merged

opam: fix issue and upgrade #54566

merged 1 commit into from Jan 25, 2019

Conversation

ChengCat
Copy link
Contributor

@ChengCat ChengCat commented Jan 25, 2019 •
edited

Motivation for this change

Fix #47544, and also upgrade to version 2.0.2.

There may be some problems with this patch. Please edit my branch if something needs to be fixed.

  • opam-mccs-darwin.patch seems to be outdated. I don't know what it does, and I don't need to run opam on MacOS.
  • Some warnings are shown when building opam, but opam seems to work fine.

@henrytill @vbgl

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vbgl
Copy link
Contributor

vbgl commented Jan 25, 2019

@GrahamcOfBorg build opam

vbgl
vbgl approved these changes Jan 25, 2019
View reviewed changes
Copy link
Contributor

@vbgl vbgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mccs has been fixed upstream: ocaml-opam/ocaml-mccs#15

@Mic92 Mic92 merged commit f9e5b73 into NixOS:master Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbgl vbgl vbgl approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OPAM: Fix bwrap mounts.
4 participants
@ChengCat @vbgl @Mic92 @GrahamcOfBorg