Mark LibreOffice dependencies as Darwin-compatible #54577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds fine on Darwin.
Builds fine on Darwin.
Builds fine on Darwin.
Builds fine on Darwin.
Builds fine on Darwin.
Builds fine on Darwin.
Builds fine on Darwin.
Builds fine on Darwin.
Builds fine on Darwin.
Builds fine on Darwin.
Builds fine on Darwin.
Builds fine on Darwin.
Builds fine on Darwin.
Builds fine on Darwin.
7c6f434c
approved these changes
Jan 25, 2019
GrahamcOfBorg
requested review from
7c6f434c,
jgeerds,
primeos,
edolstra and
dezgeg
|
hem @GrahamcOfBorg build python37Packages.tlsh |
|
Oh right, ofborg requested my review on the commit I have already approved. |
7c6f434c
approved these changes
Jan 25, 2019
matthewbauer
approved these changes
Jan 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Part of #54573.
These all build fine on Darwin -- I don't think there's any reason for them to have been marked Linux-only.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)