Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghcHEAD to ghc-8.8 #54569

Merged
merged 3 commits into from Jan 25, 2019
Merged

ghcHEAD to ghc-8.8 #54569

merged 3 commits into from Jan 25, 2019

Conversation

deepfire
Copy link
Contributor

@deepfire deepfire commented Jan 25, 2019 •
edited

  1. This causes a haskell-wide rebuild because of the change in generic-builder.nix -- perhaps this should target the staging branch instead?
  2. I'm seeing a lot of haddock SIGSEGVs.
  3. There's a bunch of overrides for common packages to be made in ghcHEAD's configuration -- I think that's better submitted as a separate PR.

@peti
Copy link
Member

peti commented Jan 25, 2019

Perhaps this should target the staging branch instead?

haskell-updates is a good target for these kind of more extensive changes.

@peti peti changed the base branch from master to haskell-updates January 25, 2019 10:52
@peti peti force-pushed the haskell-updates branch 2 times, most recently from 5ac7202 to e51f959 Compare January 25, 2019 10:54
@peti
Copy link
Member

peti commented Jan 25, 2019

@GrahamcOfBorg build cabal2nix

@deepfire
Copy link
Contributor Author

Thank you, @peti !

@peti peti merged commit 489a808 into NixOS:haskell-updates Jan 25, 2019
@deepfire deepfire deleted the ghc-8.8 branch January 27, 2019 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
6.topic: haskell 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@deepfire @peti @GrahamcOfBorg