Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruby: 2.5.3 -> 2.6.1 #54582

Closed
wants to merge 1 commit into from
Closed

ruby: 2.5.3 -> 2.6.1 #54582

wants to merge 1 commit into from

Conversation

alyssais
Copy link
Member

Motivation for this change

I tested this with nix-review a little while ago and everything built okay, but breakages are likely to occur at runtime anyway.

Since I'm not going to go through every Ruby package one at a time, I think the best thing to do is bump this so we can get bug reports of breakages from people who actually use those packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I tested this with nix-review a little while ago and everything built
okay, but breakages are likely to occur at runtime anyway.

Since I'm not going to go through every Ruby package one at a time, I
think the best thing to do is bump this so we can get bug reports of
breakages from people who actually use those packages.
@thefloweringash
Copy link
Member

FYI, Ruby 2.6.0 has a known bug that affects http. Details at Ruby Bug #15468 and ruby/ruby#2058.

@samueldr
Copy link
Member

There's not much to prepare, but maybe let's prepare for switching to it once 2.6.1 is released? (Assuming it releases with the fix.)

@alyssais alyssais added the 2.status: wait-for-upstream Waiting for upstream fix (or their other action). label Jan 26, 2019
@alyssais
Copy link
Member Author

rubygems/rubygems#2587 affects us also – (some?) gems don't seem to build using our buildRubyGem stuff because of a regression in RubyGems. It's been fixed in master, but we probably want to wait for a Ruby release that includes a RubyGems release with the fix.

@alyssais
Copy link
Member Author

Also lsegal/yard#1218 seems to affect quite a few gems if they're built with documentation, but that's easy to work around.

@alyssais
Copy link
Member Author

I just merged #54939, but it doesn’t include the RubyGems fix. I don’t think we should merge this without it. Perhaps we could just update the RubyGems we ship with Ruby…

@alyssais alyssais changed the title ruby: 2.5.3 -> 2.6.0 ruby: 2.5.3 -> 2.6.1 Jan 31, 2019
@lheckemann
Copy link
Member

@GrahamcOfBorg test redmine gitlab

These use ruby, I guess?

@ryantm ryantm added 2.status: wait-for-upstream Waiting for upstream fix (or their other action). and removed 2.status: wait-for-upstream Waiting for upstream fix (or their other action). labels Feb 26, 2019
@Mic92
Copy link
Member

Mic92 commented Feb 26, 2019

Gitlab is best to be tested not on ofborg. The test timeouts because it loads a lot of of files via qemu's p9 files systems.

@lheckemann
Copy link
Member

No, in this instance it's a real failure in dependencies.

@alyssais
Copy link
Member Author

alyssais commented Apr 28, 2019 via email

@alyssais alyssais changed the base branch from master to staging May 1, 2019 23:25
@alyssais
Copy link
Member Author

alyssais commented May 1, 2019

I’ve been using this in my config for ages now, and haven’t seen any problems that were not addressed by #60394, so I intend to merge this in the next couple of days unless anyone objects.

@ghost
Copy link

ghost commented May 4, 2019

I tried using this but saw the problem with redis-rack from #60676 again. I manually cherry-picked the rubygems update from staging and this.
If it doesn't affect any existing packages this shouldn't prevent you from merging this, but I suspect the problem with rubygems/rubygems#2587 is still present.

@alyssais
Copy link
Member Author

alyssais commented May 4, 2019

Thanks @petabyteboy. Given how annoying that issue is to work around for the people who are most likely to benefit from this change, I’ll hold off merging this for now and see what can be done about that issue.

@alyssais alyssais removed the 2.status: wait-for-upstream Waiting for upstream fix (or their other action). label May 6, 2019
@alyssais
Copy link
Member Author

alyssais commented May 7, 2019 via email

@ghost
Copy link

ghost commented May 7, 2019

After thinking about this, I think we should backport the fix to
RubyGems 3.0.3, and then make Ruby 2.6 the default Ruby.

Agreed.
I will test again with the rubygems update, this and alyssais@06bd012

@ghost
Copy link

ghost commented May 8, 2019

Unfortunately the problem was still present, even with the patch applied:
https://github.com/petabyteboy/nixpkgs/commits/feature/ruby
Is there anything obvious I'm missing?

@alyssais
Copy link
Member Author

alyssais commented May 18, 2019 via email

@ghost
Copy link

ghost commented May 19, 2019

With all commits in staging concerning ruby and those from the PR you mentioned cherry-picked I still run into the same problem.

Edit: Nevermind, with this tree it worked: https://github.com/petabyteboy/nixpkgs/commits/feature/ruby

@alyssais
Copy link
Member Author

Edit: Nevermind, with this tree it worked: petabyteboy/nixpkgs:ruby@feature (commits)

Would you mind posting this sort of thing as a separate comment in future? I didn't see this until now because GitHub doesn't notify for edits, and had spent days wondering how it could still be broken.

@ghost
Copy link

ghost commented May 24, 2019

Sorry, I will do that if I remember. There are no issues anymore from my side, as long as we apply the patch for rubygems#2587 before updating.

@ghost
Copy link

ghost commented Aug 26, 2019

Is there any new or existing reason not to merge this?

@manveru
Copy link
Contributor

manveru commented Aug 27, 2019

I think before we merge this, we should upgrade ruby to 2.6.3 as well as rubygems and see if that addresses the issue.

@ghost
Copy link

ghost commented Aug 27, 2019

ruby_2_6 is already on 2.6.3 in unstable.
The rubygems version 3.0.3 should already have the fix, but 3974254f6a20191b6b07621f6ea928be75dad121 and dfe7e42ff5844a4fe9901ce1be6125127085e044 are required to make use of our own rubygems. The rubygems included in ruby 2.6.3 still has the issue.
I could build mastodon successfully with https://github.com/petabyteboy/nixpkgs/commits/feature/ruby-testing.

@ghost ghost mentioned this pull request Aug 27, 2019
10 tasks
@lheckemann
Copy link
Member

Friendly reminder that the branch-off is in 11 days — do you want this in 19.09 and what do you think the chances of it being ready on time are?

@ghost
Copy link

ghost commented Aug 27, 2019

I think it's very realistic to make it before the branch-off. All the fixes have been committed since months. If we can merge it before that would be great, but if it doesn't work out that's not too bad either.

@ghost ghost mentioned this pull request Aug 28, 2019
10 tasks
@matthewbauer matthewbauer modified the milestones: 19.03, 20.03 Aug 28, 2019
@alyssais
Copy link
Member Author

Closing in favour of #67597.

@alyssais alyssais closed this Aug 31, 2019
@alyssais alyssais deleted the ruby branch August 31, 2019 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet