New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ruby: 2.5.3 -> 2.6.1 #54582
ruby: 2.5.3 -> 2.6.1 #54582
Conversation
I tested this with nix-review a little while ago and everything built okay, but breakages are likely to occur at runtime anyway. Since I'm not going to go through every Ruby package one at a time, I think the best thing to do is bump this so we can get bug reports of breakages from people who actually use those packages.
FYI, Ruby 2.6.0 has a known bug that affects http. Details at Ruby Bug #15468 and ruby/ruby#2058. |
There's not much to prepare, but maybe let's prepare for switching to it once 2.6.1 is released? (Assuming it releases with the fix.) |
rubygems/rubygems#2587 affects us also – (some?) gems don't seem to build using our |
Also lsegal/yard#1218 seems to affect quite a few gems if they're built with documentation, but that's easy to work around. |
I just merged #54939, but it doesn’t include the RubyGems fix. I don’t think we should merge this without it. Perhaps we could just update the RubyGems we ship with Ruby… |
@GrahamcOfBorg test redmine gitlab These use ruby, I guess? |
Gitlab is best to be tested not on ofborg. The test timeouts because it loads a lot of of files via qemu's p9 files systems. |
No, in this instance it's a real failure in dependencies. |
Aforementioned RubyGems upgrade is #60394. After that's merged, this is
good to go from my PoV.
|
I’ve been using this in my config for ages now, and haven’t seen any problems that were not addressed by #60394, so I intend to merge this in the next couple of days unless anyone objects. |
I tried using this but saw the problem with redis-rack from #60676 again. I manually cherry-picked the rubygems update from staging and this. |
Thanks @petabyteboy. Given how annoying that issue is to work around for the people who are most likely to benefit from this change, I’ll hold off merging this for now and see what can be done about that issue. |
So, I definitely think we should hold off on this until the gem build
issue is addressed.
To address that, we have a few options:
1. Apply that patch to our packaged RubyGems 3.0.3. This is what Fedora
has done.
2. Wait for a new release of RubyGems that includes the fix.
3. Wait for a new release of RubyGems that includes the fix, and then a
new release of Ruby that includes that version of RubyGems.
On one hand, it's probably not hurting anybody that Ruby 2.5 is the
default instead of 2.6. On the other, we should probably fix Ruby 2.6
anyway for people who need that version, and if we're going to do that
(by backporting the patch), we'll have a working 2.6 so might as well
update the default anyway.
After thinking about this, I think we should backport the fix to
RubyGems 3.0.3, and then make Ruby 2.6 the default Ruby.
I'd like to hear opinions from at least one other person before I do
anything though, so: thoughts?
|
Agreed. |
Unfortunately the problem was still present, even with the patch applied: |
Unfortunately the problem was still present, even with the patch applied:
https://github.com/petabyteboy/nixpkgs/commits/feature/ruby
|
With all commits in staging concerning ruby and those from the PR you mentioned cherry-picked I still run into the same problem. Edit: Nevermind, with this tree it worked: https://github.com/petabyteboy/nixpkgs/commits/feature/ruby |
Would you mind posting this sort of thing as a separate comment in future? I didn't see this until now because GitHub doesn't notify for edits, and had spent days wondering how it could still be broken. |
Sorry, I will do that if I remember. There are no issues anymore from my side, as long as we apply the patch for rubygems#2587 before updating. |
Is there any new or existing reason not to merge this? |
I think before we merge this, we should upgrade ruby to 2.6.3 as well as rubygems and see if that addresses the issue. |
ruby_2_6 is already on 2.6.3 in unstable. |
Friendly reminder that the branch-off is in 11 days — do you want this in 19.09 and what do you think the chances of it being ready on time are? |
I think it's very realistic to make it before the branch-off. All the fixes have been committed since months. If we can merge it before that would be great, but if it doesn't work out that's not too bad either. |
Closing in favour of #67597. |
Motivation for this change
I tested this with nix-review a little while ago and everything built okay, but breakages are likely to occur at runtime anyway.
Since I'm not going to go through every Ruby package one at a time, I think the best thing to do is bump this so we can get bug reports of breakages from people who actually use those packages.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)