Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gprof2dot: 2015-04-27 -> 2017-09-19 #54580

Merged
merged 1 commit into from Jan 31, 2019
Merged

gprof2dot: 2015-04-27 -> 2017-09-19 #54580

merged 1 commit into from Jan 31, 2019

Conversation

pmiddend
Copy link
Contributor

Motivation for this change

The version of gprof2dot in nixpkgs was very old, so I updated it.

Also, you really need two versions of this tool: for Python 2 and Python 3. Apparently you cannot analyze profiler outputs from Python 3 with the (current) Python 2 version. I hope _py2 and _py3 are okay as prefixes?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pmiddend
Copy link
Contributor Author

@GrahamcOfBorg build gprof2dot_py2 gprof2dot_py3

@pmiddend
Copy link
Contributor Author

Any update on this?

@pmiddend pmiddend force-pushed the gprof2dot-latest branch 2 times, most recently from 4c7f5cd to d4ecedc Compare January 30, 2019 12:30
@pmiddend
Copy link
Contributor Author

@GrahamcOfBorg build python2Packages.gprof2dot python3Packages.gprof2dot

@Mic92 Mic92 merged commit 1321f17 into NixOS:master Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@FRidh FRidh FRidh left review comments

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pmiddend @Mic92 @FRidh @GrahamcOfBorg