Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] libreoffice,libreoffice-fresh: fix build on Darwin #54573

Closed
wants to merge 8 commits into from
Closed

[WIP] libreoffice,libreoffice-fresh: fix build on Darwin #54573

wants to merge 8 commits into from

Conversation

alyssais
Copy link
Member

Months of work later, there are lots of nice fixes here that are useful not just for LibreOffice, but for Darwin builds in general.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: darwin Running or building packages on Darwin 6.topic: python labels Jan 25, 2019
@alyssais
Copy link
Member Author

The very large number of additions is due to 15815aedb00873aa593f887b8f555a810ca3b1de.

grahamc
grahamc previously requested changes Jan 25, 2019
View reviewed changes
Copy link
Member

@grahamc grahamc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes to ensure my note doesn't get lost. I'm looking in to the S3 bucket we can put unstable sources in to.

@alyssais alyssais changed the title libreoffice,libreoffice-fresh: fix build on Darwin [WIP] libreoffice,libreoffice-fresh: fix build on Darwin Jan 25, 2019
@alyssais
Copy link
Member Author

I'm going to break out some smaller PRs.

@alyssais alyssais mentioned this pull request Jan 25, 2019
Merged
10 tasks
@alyssais alyssais mentioned this pull request Jan 25, 2019
Merged
10 tasks
@7c6f434c
Copy link
Member

In general seems reasonable on first reading

@alyssais
Copy link
Member Author

Looks like the net_snmp upgrade already has a PR: #51683

@alyssais alyssais dismissed grahamc’s stale review January 26, 2019 21:24

Relevant commits have been dropped.

@alyssais alyssais removed the request for review from FRidh January 26, 2019 21:28
@alyssais
Copy link
Member Author

alyssais commented Feb 8, 2019

Just need either #51683 or #54616 to be merged, and then I think this is ready.

@7c6f434c
Copy link
Member

@alyssais Indeed one of them was merged

@alyssais
Copy link
Member Author

So I saw! But unfortunately this doesn't build on latest staging, so now I need to fix that up.

@mmahut
Copy link
Member

mmahut commented Aug 20, 2019

Are there any updates on this pull request, please?

@alyssais
Copy link
Member Author

alyssais commented Aug 31, 2019 via email

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@ryantm ryantm marked this pull request as draft October 23, 2020 03:09
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 23, 2020
@stale
Copy link

stale bot commented Apr 26, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 26, 2021
@Mindavi
Copy link
Contributor

Mindavi commented Oct 13, 2021

I'm gonna close it since nobody picked this up. It's still findable if anyone wants to take this to the finish line.

@Mindavi Mindavi closed this Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc grahamc left review comments

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@andir andir Awaiting requested review from andir

@peti peti Awaiting requested review from peti

@lovek323 lovek323 Awaiting requested review from lovek323

@wkennington wkennington Awaiting requested review from wkennington

@abbradar abbradar Awaiting requested review from abbradar

@edolstra edolstra Awaiting requested review from edolstra

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 2.status: work-in-progress 6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500 11.by: nixpkgs-member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@alyssais @7c6f434c @mmahut @Mindavi @grahamc @ryantm @GrahamcOfBorg