Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

liferea: 1.12.4 -> 1.12.6 #54583

Merged
merged 1 commit into from Jan 26, 2019
Merged

liferea: 1.12.4 -> 1.12.6 #54583

merged 1 commit into from Jan 26, 2019

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Jan 25, 2019

Motivation for this change

Bugfix releases.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@etu etu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like to see some small changes for this mentioned inline

@etu
Copy link
Contributor

etu commented Jan 25, 2019

A squash would still be nice to have of the two commits 👍

@samueldr samueldr merged commit a7df44f into NixOS:master Jan 26, 2019
@vbgl vbgl deleted the liferea-1.12.6 branch January 26, 2019 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants