zxing-cpp: init at git-20180320 #54572
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This port takes considerably less space in nix store, usecases: containers, squashfs, iso images
symphorien
reviewed
Jan 25, 2019
| sha256 = "07xshbh656a26bi8bii6ffw3fahnfj6755f6ybmmmplk55xxnlg8"; | ||
| }; | ||
|
|
||
| nativeBuildInputs = [ pkgconfig cmake makeWrapper ]; |
symphorien
reviewed
Jan 25, 2019
| }; | ||
|
|
||
| nativeBuildInputs = [ pkgconfig cmake makeWrapper ]; | ||
| cmakeFlags = [ "-DCMAKE_BUILD_TYPE=Release" ]; |
There was a problem hiding this comment.
Apparently this is unnecessary:
|
(tried to search for ZXing-cpp) argh, apparently there are multiple forks of ZXing C++ code around, with apparently unrelated further development histories. Do we want to disambiguate/prevent future ambiguity? |
|
Are there any updates on this pull request, please? |
|
I'm closing as OP has no intention to comment or fix the issues raised in review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This port takes considerably less space in nix store,
usecases: containers, squashfs, iso images
Motivation for this change
When storage space is at a premium, like a netboot image, this helps by not requiring java deps.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)