ktouch: init at 18.12.0 #53859
ktouch: init at 18.12.0 #53859
Conversation
This package contains several CMake files used for setting up its
provided tools for use in other projects build with CMake.
While packaging *ktouch* I found out that the ${_qt5Core_install_prefix}
variable doesn't expand at all, rendering the path to the `qmlcachegen`
binary useless. As a fix, the command itself is used instead of the path
to the binary.
|
@ttuegel I guess a backport would then have to go to staging-18.09, right? |
| find_package(Qt5 COMPONENTS Qml Core) | ||
|
|
||
| - set(compiler_path "${_qt5Core_install_prefix}/bin/qmlcachegen") | ||
| + set(compiler_path "qmlcachegen") |
There was a problem hiding this comment.
Maybe we should also propose upstream this. It would help with cross-compilation.
There was a problem hiding this comment.
Shall I take care of bringing this upstream?
There was a problem hiding this comment.
Although I'm afraid this might get rejected: Qt stores a lot of its development tools under /var/lib{,exec} , which in most FHS distros is not in PATH. So our approach of relying the binary to be in our PATH won't work there.
|
Maybe the |
packaging the `ktouch` touch typing tutor. Due to Qt impurities, it needs to be installed in a profile to find it runtime dependencies.
|
After building all dependencies overnight, I discovered that one run-time dependecy was missing and added it. @Mic92 squashing is done. |
|
backport: #53887 |
|
On Hydra this package never built successfully on master: https://hydra.nixos.org/job/nixpkgs/trunk/ktouch.x86_64-linux/all Now reported as #56097 However, on 18.09 it does build. |
Motivation for this change
Follow-up to #53256
A small fix for qtdeclarative was necessary to get it built (see respective commit), which causes plenty of rebuilds of dependants.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)