llvm_6, llvm_7: build all default targets #53941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7c6f434c
approved these changes
Jan 14, 2019
Mic92
approved these changes
Jan 14, 2019
Mic92
reviewed
Jan 14, 2019
| @@ -28,9 +26,6 @@ let | |||
| shortVersion = with stdenv.lib; | |||
| concatStringsSep "." (take 1 (splitString "." release_version)); | |||
|
|
|||
| inherit | |||
| (import ../common.nix { inherit (stdenv) lib; }) | |||
| llvmBackendList; | |||
There was a problem hiding this comment.
Do we still need common.nix in that case?
There was a problem hiding this comment.
No, indeed. Removed.
|
Assuming it evals, 👍 :).
…On Mon, 14 Jan 2019 17:35:49 +0000 (UTC), Orivej Desh ***@***.***> wrote:
orivej commented on this pull request.
> @@ -28,9 +26,6 @@ let
shortVersion = with stdenv.lib;
concatStringsSep "." (take 1 (splitString "." release_version));
- inherit
- (import ../common.nix { inherit (stdenv) lib; })
- llvmBackendList;
No, indeed. Removed.
--
You are receiving this because your review was requested.
Reply to this email directly or view it on GitHub:
#53941 (comment) part: text/html
|
|
Did aarch64 build succeed before? |
|
At least llvm_7 used to build on aarch64, because we are using this version for rust. |
|
llvm_7 still builds on aarch64, but llvm_6 needs a backport of this fix: https://reviews.llvm.org/D50583. (This is similar to an older https://reviews.llvm.org/D28285.) |
This makes LLVM tools (including dependent tools such as LLD) readily useful in more situations, foresees such needed additions as BPF and NVPTX, and brings llvm_6 and newer on par with the current default llvm_5.
|
@GrahamcOfBorg build llvm_6 llvm_7 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This makes LLVM tools (including dependent tools such as LLD) readily useful in
more situations, foresees such future additions as BPF and NVPTX, and brings
llvm_6 and newer on par with the current default llvm_5.
The list of targets was reduced in #52031, which was not necessary to fix cross compilation.
BPF target is needed for BCC in #53920.
outandlibsize increases by 1/3, but the full LLVM is needed regardless, and this avoids having a partial LLVM.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)