Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6408: Improve wording of the dragging signal distance tooltips (juanjo) #7055

Merged

Conversation

Alberth289346
Copy link
Contributor

Fixes #6408

Didn't change the string name, since that gives the translators the option to see how the English version changed. (Otherwise, you'd have two unrelated string changes which won't be connected with each other.)

@LordAro LordAro merged commit f4b8a67 into OpenTTD:master Jan 13, 2019
@Alberth289346 Alberth289346 deleted the 6408-improve-signal-distance-helptext branch January 13, 2019 08:08
@J0anJosep
Copy link
Contributor

J0anJosep commented Jan 13, 2019

I just filled in an issue. Alberth did write the patch.

@Alberth289346
Copy link
Contributor Author

You also provided the solution, I merely converted it to computer-readable form.
In my view, that makes you more the spiritual parent than me, but let's not argue over a patch that changes 3 words in a language file.

@J0anJosep
Copy link
Contributor

I expected some further discussion about how to word them. The proposal of changing "density" to "distance" was the first thing that came to my mind to explain the issue. I didn't see it as a solution when I posted the issue.

nielsmh pushed a commit to nielsmh/OpenTTD that referenced this pull request Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants