Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linuxPackages.virtualboxGuestAdditions: fix build after xorg 1.20 #53867

Closed
wants to merge 1 commit into from
Closed

linuxPackages.virtualboxGuestAdditions: fix build after xorg 1.20 #53867

wants to merge 1 commit into from

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Jan 13, 2019

Motivation for this change

The build fails on trunk: https://hydra.nixos.org/build/87258883/nixlog/1 :

install: cannot stat 'other/vboxvideo_drv_120.so': No such file or directory

This blocks the ova test on trunk-combined.

So we still need to force the ABI version to 118 it seems.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hedning
linuxPackages.virtualboxGuestAdditions: fix build after xorg 1.20
090de49 
We still need to force the ABI version to 118 it seems.
@hedning hedning requested a review from vcunat January 13, 2019 08:34
@hedning hedning mentioned this pull request Jan 13, 2019
Closed
@vcunat vcunat self-assigned this Jan 13, 2019
@vcunat
Copy link
Member

vcunat commented Jan 13, 2019

Thanks. Except I'd prefer to keep the expression working with 119 as well, so I pushed 626233e.

I suspect there's a better way for this thing via #50280 but I just don't have energy to solve everything...

@vcunat vcunat closed this in 626233e Jan 13, 2019
voobscout pushed a commit to voobscout/nixpkgs that referenced this pull request Jan 16, 2019
@vcunat @voobscout
linuxPackages.virtualboxGuestAdditions: fix build after xorg 1.20
321e413 
We still need to force the ABI version to 118 it seems.
Close NixOS#53867
@hedning hedning deleted the fix-vbox-guest-additions branch October 15, 2019 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat Awaiting requested review from vcunat

@svanderburg svanderburg Awaiting requested review from svanderburg

Assignees

@vcunat vcunat

Labels
1.severity: blocker 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hedning @vcunat @GrahamcOfBorg