Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set company colour per vehicle group #6919

Closed
andythenorth opened this issue Sep 25, 2018 · 1 comment
Closed

Set company colour per vehicle group #6919

andythenorth opened this issue Sep 25, 2018 · 1 comment
Labels
enhancement Issue would be a good enhancement; we accept Pull Requests!

Comments

@andythenorth
Copy link
Contributor

andythenorth commented Sep 25, 2018

Current

Company colours are set per company, and optionally per vehicle type, with some more detailed options for e.g. Steam, Diesel, Passenger coach etc.

Desired

Ability to set company colours independently for each group in vehicle groups.

I haven't tried to specify how the UI might work as choices might be limited by implementation details.

Bonus Prize 1

Additionally the UI is also weird and hard to use, requiring player to combine both checkboxes and dropdown choices to set or unset the colours. Could it be easier to use?

Bonus Prize 2

The existing 'detailed' choices by vehicle type are incomplete or odd. Examples:

  • there are limited options for RVs, ships, aircraft vs. trains, e.g. no Steam Lorry etc
  • for trains, the options conflate power type and railtype, e.g. Steam, Diesel, Maglev, Monorail
  • there's no support for liveries by newgrf railtype
  • 'Passenger Coach' also changes the colour of mail vehicles, and vehicles with no cargo type. This is non-obvious
  • A diesel pax railcar will use 'Diesel Engine', rather than 'Passenger Coach (Diesel)'; there is no obvious answer about which is correct, both would have disadvantages

Rather than extending this to all types, it would be better IMHO to remove some of the options, or at least have a consistent approach across types. Changing familiar things will inevitably cause some player complaints, but it would be worth improving this.

-- WIP --

PeterN started a group livery branch, but it stalled for PeterN reasons (broken dev environment).

https://github.com/PeterN/OpenTTD/tree/group-livery

@andythenorth andythenorth added the enhancement Issue would be a good enhancement; we accept Pull Requests! label Jan 7, 2019
@andythenorth
Copy link
Contributor Author

Requesting features isn't how they get done eh :) @PeterN will either get motivated to fix the patch, or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue would be a good enhancement; we accept Pull Requests!
Projects
None yet
Development

No branches or pull requests

1 participant