Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mate updates and downgrades #53944

Merged
merged 36 commits into from Jan 21, 2019

Conversation

worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Jan 14, 2019

Motivation for this change

Sometime last july r-ryantm sent prs to update mate to its unstable release.
Unfortunately those got merged and it went under the radar.
I noticed this in #50695

To prevent this from happening again the mate attribute has been blacklisted for nixpkgs-update.

This should undo that and also update other applications to their latest stable release.

Fixes #53758 #53836

cc @romildo @lheckemann

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Jan 14, 2019

cc @johannesloetzsch

@worldofpeace
Copy link
Contributor Author

So I've cleaned some things up and got mozo to function.

Also tested execution of pretty much everything in a vm with mate enabled.

@worldofpeace
Copy link
Contributor Author

@Mic92 since this has left stable in a pretty poor shape, do you think we should backport this?

@lheckemann
Copy link
Member

lheckemann commented Jan 16, 2019

Yes, I'm in favour of backporting.

EDIT: Does user config remain compatible if you run 1.21? If it does some sort of schema upgrades that make a downgrade impossible that would be a pain…

@Mic92
Copy link
Member

Mic92 commented Jan 16, 2019

@worldofpeace ok from my side, when you have tested this.

@worldofpeace
Copy link
Contributor Author

worldofpeace commented Jan 16, 2019

EDIT: Does user config remain compatible if you run 1.21? If it does some sort of schema upgrades that make a downgrade impossible that would be a pain…

This was a thought that I was also having.
I'm not sure where I can look to see if this would be a problem, but the best I could do is simulate this upgrade from within a vm and see if we have problems.

Or find someone who currently uses mate on 18.09 who'd be willing to test this.

@worldofpeace
Copy link
Contributor Author

Though to begin a backport pr this needs to be merged first 😄

Just need approval for f9b8f2c...e26d22c

@RedL0tus
Copy link

Any updates on this? I'm currently using MATE and it seems MATE 1.21 isn't fully compatible with themes like arc or materia, downgrading to 1.20 would be great!

@worldofpeace
Copy link
Contributor Author

Any updates on this? I'm currently using MATE and it seems MATE 1.21 isn't fully compatible with themes like arc or materia, downgrading to 1.20 would be great!

I just need a review for those range of commits, @jtojnar mind giving them a look?

@jtojnar
Copy link
Contributor

jtojnar commented Jan 21, 2019

That looks fine to me.

@worldofpeace
Copy link
Contributor Author

worldofpeace commented Jan 21, 2019

That looks fine to me.

Great, as I've already tested this in a vm and determined It looked good, I'm going for it 😄

@worldofpeace worldofpeace merged commit d75457c into NixOS:master Jan 21, 2019
@worldofpeace worldofpeace deleted the mate/downgrade-to-stable branch January 21, 2019 06:49
@worldofpeace
Copy link
Contributor Author

I'm going to assemble the backport now.

@RedL0tus
Copy link

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants