Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tahoe-lafs: 1.12.1 -> 1.13.0 #53873

Merged
merged 1 commit into from Feb 21, 2019
Merged

tahoe-lafs: 1.12.1 -> 1.13.0 #53873

merged 1 commit into from Feb 21, 2019

Conversation

tilpner
Copy link
Member

@tilpner tilpner commented Jan 13, 2019 •
edited

Motivation for this change

I've never used tahoe-lafs before, 1.13 is apparently needed for wormhole invitiations.
I bumped version and hash, and then added packages until the tests passed, but I don't
know if any changes to the pre*/post* are needed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @exarkun @MostAwesomeDude

@tilpner
Copy link
Member Author

tilpner commented Jan 13, 2019

@GrahamcOfBorg build tahoe-lafs

MostAwesomeDude
MostAwesomeDude suggested changes Feb 11, 2019
View reviewed changes
Copy link
Contributor

@MostAwesomeDude MostAwesomeDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for doing this! I appreciate it.

pkgs/tools/networking/p2p/tahoe-lafs/default.nix Outdated
@@ -56,7 +56,7 @@ pythonPackages.buildPythonApplication rec {
propagatedBuildInputs = with pythonPackages; [
twisted foolscap nevow simplejson zfec pycryptopp darcsver
setuptoolsTrial setuptoolsDarcs pycrypto pyasn1 zope_interface
service-identity pyyaml
service-identity pyyaml magic-wormhole hypothesis treq
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that Hypothesis needs to be propagated; could you instead put it in checkInputs or possibly buildInputs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MostAwesomeDude I added it to checkInputs, and everything seems to still work

@grahamc
Copy link
Member

grahamc commented Feb 14, 2019

I'd prefer +1 from @MostAwesomeDude prior to merging

@MostAwesomeDude
Copy link
Contributor

Let's merge it.

I have, after chatting with upstream, learned that the breakage of tahoe start and friends is semi-intentional and won't be fixed. I am otherwise able to get the client to locally work with the newer tahoe run subcommand. If there's further breakage, I haven't found it.

@manveru
Copy link
Contributor

manveru commented Feb 20, 2019

Please merge this so I can use it as base for my Gridsync PR :)

@srhb srhb merged commit 9c26b10 into NixOS:master Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MostAwesomeDude MostAwesomeDude MostAwesomeDude requested changes

@dasJ dasJ dasJ approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@tilpner @grahamc @MostAwesomeDude @manveru @dasJ @srhb @GrahamcOfBorg