tahoe-lafs: 1.12.1 -> 1.13.0 #53873
Merged
tahoe-lafs: 1.12.1 -> 1.13.0 #53873
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build tahoe-lafs |
GrahamcOfBorg
added
10.rebuild-darwin: 0
MostAwesomeDude
suggested changes
Feb 11, 2019
| @@ -56,7 +56,7 @@ pythonPackages.buildPythonApplication rec { | |||
| propagatedBuildInputs = with pythonPackages; [ | |||
| twisted foolscap nevow simplejson zfec pycryptopp darcsver | |||
| setuptoolsTrial setuptoolsDarcs pycrypto pyasn1 zope_interface | |||
| service-identity pyyaml | |||
| service-identity pyyaml magic-wormhole hypothesis treq | |||
There was a problem hiding this comment.
I don't think that Hypothesis needs to be propagated; could you instead put it in checkInputs or possibly buildInputs?
There was a problem hiding this comment.
@MostAwesomeDude I added it to checkInputs, and everything seems to still work
tilpner
force-pushed
the
tahoelafs-update
branch
from
6a6b0f1 to
0ce675a
Compare
|
I'd prefer +1 from @MostAwesomeDude prior to merging |
|
Let's merge it. I have, after chatting with upstream, learned that the breakage of |
|
Please merge this so I can use it as base for my Gridsync PR :) |
dasJ
approved these changes
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I've never used tahoe-lafs before, 1.13 is apparently needed for wormhole invitiations.
I bumped version and hash, and then added packages until the tests passed, but I don't
know if any changes to the
pre*/post*are needed.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)cc @exarkun @MostAwesomeDude