Change #6060: Allow drawing dropdown lists with scrollbars above and fix scrolling movement #7056
+39
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andythenorth
previously approved these changes
Jan 13, 2019
andythenorth
dismissed
their stale review
I only tested it, didn't review code, bit premature.
LordAro
reviewed
Jan 13, 2019
… above the widgets
…scroll it to its very bottom. This "prevents" the fast movement towards the bottom when holding down the mouse button.
…ot fit the screen.
J0anJosep
commented
Jan 14, 2019
| @@ -3516,8 +3516,9 @@ void ChangeVehicleViewports(VehicleID from_index, VehicleID to_index) | |||
| */ | |||
| void RelocateAllWindows(int neww, int newh) | |||
| { | |||
| Window *w; | |||
| DeleteWindowById(WC_DROPDOWN_MENU, 0); | |||
There was a problem hiding this comment.
Should I open another PR for this?
There was a problem hiding this comment.
@LordAro
I saw your comment about:
i feel like max<uint> would be cleaner - no need to cast after the function call (+ available_height_above below)
... but cannot find it now on GitHub.
I think the parameters of the max function can be negative. I prefer making the cast after the max is calculated (it won't be negative). Is it really necessary to use max<uint> ?
There was a problem hiding this comment.
I deleted it because I saw it was stupid, don't worry about it :)
LordAro
approved these changes
Jan 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite of the code for choosing where to open a dropdown.
With this patch, dropdown can be created above the opening widget and with scrollbar enabled.
In case of opening above and with scrollbar, list is moved to show the last items. Otherwise, if mouse button is held down, it starts scrolling down without moving the mouse.