Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/containers: explicitly set link up on host for extraVeths #53871

Merged
merged 1 commit into from Jan 14, 2019

Conversation

elseym
Copy link
Member

@elseym elseym commented Jan 13, 2019

Motivation for this change

right now, the link state on the host side of a container's extraveth-pair is implicitly set up through dhcp. having dhcp disabled on the host seems to break containers declaratively configuring extraveths, because the poststart script tries to add routes while the targeted interface is still down.

this change explicitly calls ip link up on any additional extraveths on the host side before configuring routes (in parity to the interface setup script for the container side).
also, the test has been updated to not depend on dhcp anymore.

/cc @fpletz

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debugged & verified with @elseym.

@fpletz fpletz merged commit ca06398 into NixOS:master Jan 14, 2019
@fpletz fpletz deleted the fix-container-extraveths branch January 14, 2019 04:01
@arianvp
Copy link
Member

arianvp commented Jan 14, 2019

Great stuff. We should at sometime make 'nixos-container behave more like systemd-nspawn upstream and use the upstream systemd-networkd config so that these kind of bugs happen less.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants