nixos/containers: explicitly set link up on host for extraVeths #53871
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
right now, the link state on the host side of a container's extraveth-pair is implicitly set up through dhcp. having dhcp disabled on the host seems to break containers declaratively configuring extraveths, because the poststart script tries to add routes while the targeted interface is still down.
this change explicitly calls ip link up on any additional extraveths on the host side before configuring routes (in parity to the interface setup script for the container side).
also, the test has been updated to not depend on dhcp anymore.
/cc @fpletz
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)