Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

powerdns: fix ecdsa support #53842

Merged
merged 1 commit into from Jan 14, 2019
Merged

powerdns: fix ecdsa support #53842

merged 1 commit into from Jan 14, 2019

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Jan 12, 2019

Motivation for this change

I wanted to deploy DNSSEC on one of my systems, but the algorithm I wanted to use (13, aka ECDSAP256SHA256) was not available.

This change also allows us to drop the patch that skips the sha384 test.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ajs124
powerdns: fix ecdsa support
15c6293 
add libressl, drop patch
neither openssl 1.0 (headers not found) nor openssl 1.1 (configuration
failed when trying to test constants) work, but libressl does
@Mic92
Copy link
Member

Mic92 commented Jan 13, 2019

@GrahamcOfBorg build powerdns

@Mic92
Copy link
Member

Mic92 commented Jan 13, 2019

@GrahamcOfBorg build nixosTests.powerdns

@flokli
Copy link
Contributor

flokli commented Jan 14, 2019

Well, I'm fine with building this with libressl too.

In case somebody wants to take a look into how this can be built with openssl too, he can take a look later too :-)

@flokli flokli merged commit 5c2f09a into NixOS:master Jan 14, 2019
@ajs124 ajs124 deleted the powerdns_ecda branch January 14, 2019 16:58
@vcunat
Copy link
Member

vcunat commented Sep 4, 2019

See #67601 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli left review comments

@disassembler disassembler Awaiting requested review from disassembler

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ajs124 @Mic92 @flokli @vcunat @GrahamcOfBorg