Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/gitea: minor fixes #53952

Merged
merged 2 commits into from Jan 15, 2019
Merged

nixos/gitea: minor fixes #53952

merged 2 commits into from Jan 15, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jan 14, 2019 •
edited

Motivation for this change

The first commit adds an option disableRegistration which disables the sign up form anybody could use. Although this can be done using extraConfig I figured that such an important option should be promoted by our manual as most of the self-hosted gitea instances aren't intended for common use.

The second commit adds gitAndTools.git to the service's path to ensure that git is available in the runtime of gitea.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
nixos/gitea: add option to disable registration
ad3a50e 
Although this can be added to `extraOptions` I figured that it makes
sense to add an option to explicitly promote this feature in our
documentation since most of the self-hosted gitea instances won't be
intended for common use I guess.

Also added a notice that this should be added after the initial deploy
as you have to register yourself using that feature unless the install
wizard is used.
@Ma27
nixos/gitea: add git to the service path
f90bd42 
Otherwise commands like `git push` will fail if the machine doesn't have
git installed.
@Ma27 Ma27 requested a review from infinisil as a code owner January 14, 2019 15:08
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jan 14, 2019

@GrahamcOfBorg test gitea

rnhmjoj
rnhmjoj approved these changes Jan 14, 2019
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried running the server in a VM, registering a user, disabling registration and logging in. Everything works correctly.

@dywedir dywedir merged commit 95a0e24 into NixOS:master Jan 15, 2019
@Ma27 Ma27 deleted the improve-gitea-module branch January 15, 2019 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ma27 @rnhmjoj @dywedir @GrahamcOfBorg