New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nicotineplus: init at 1.4.1 #53861
nicotineplus: init at 1.4.1 #53861
Conversation
Added myself (6AA4FD) to maintainer list
Also, if you intend to submit other prs in the future, they should be checked out to a branch from master and not on master itself. Other than that it's nice to see our maintainers list grow ✨ |
alright. everything looks good on my end, and i'll use branches on my fork instead of master for future commits. |
Builds locally and executes, though there is this warning
Please squash your commits into one with a message identical to your pr title aside from the changed attribute |
i'm happy to do that, but i've just realized that #53717 predates this, and seems to be better put together, so perhaps that should be tested+merged instead? |
Looks like that was merged. Closing. |
Added myself (6AA4FD) to maintainer list
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)