Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mediathekview: 9 -> 13.2.1 #53845

Closed
wants to merge 1 commit into from
Closed

Conversation

fighterhero
Copy link

@fighterhero fighterhero commented Jan 12, 2019

Motivation for this change

Mediathekview has been out of date for a while. The project has its own website now https://mediathekview.de/ (warning its in german). This is my first contribution to nixpkgs so I appologize for any inconvenience in advance. I also know that this is a litte bit of a niche thing.

Things done

Upgrade is from version 9 to 13.2.1. I also took the liberty to switch us to tar, since both releases are available. Further I specified oraclejre, instead of jre to avoid issues.
I kept the maintainer as is.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [ x ] NixOS
    • macOS
    • [ x ] other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@davidak
Copy link
Member

davidak commented Jan 24, 2019

It was already updated 5 days ago by @Moredread cc @chaoflow.

88098b1#diff-3a8246c1b5222a74337f074a18cab535

@dotlambda dotlambda closed this Jan 24, 2019
@Moredread
Copy link
Contributor

@fighterhero Thanks for your PR! I had my PR on the back burner for quite a while, so it was a bit unfortunate, that I just updated it a few days earlier than you posted yours!

Your PR looks quite good, so I'm sure it would have been merged if I hadn't updated mine.

I hope you aren't discouraged from contributing in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants