Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt5: use 5.11 on darwin until it's fixed #53846

Merged
merged 1 commit into from Jan 12, 2019
Merged

qt5: use 5.11 on darwin until it's fixed #53846

merged 1 commit into from Jan 12, 2019

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Jan 12, 2019

Fixes: 8e811ec ('qt5: 5.11 -> 5.12')
Resolves: #53841

Motivation for this change

qt512 is not working on Darwin currently

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
qt5: use 5.11 on darwin until it's fixed
37e4390 
Fixes: 8e811ec ('qt5: 5.11 -> 5.12')
Resolves: #53841
ttuegel
ttuegel approved these changes Jan 12, 2019
View reviewed changes
Copy link
Member

@ttuegel ttuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks!

@ttuegel ttuegel merged commit 4d2a989 into master Jan 12, 2019
@veprbl veprbl deleted the pr/qt5-darwin-fix branch January 14, 2019 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 101-500 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@veprbl @ttuegel @GrahamcOfBorg