Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

root, root5: fix on darwin #53825

Merged
merged 2 commits into from Jan 12, 2019
Merged

root, root5: fix on darwin #53825

merged 2 commits into from Jan 12, 2019

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Jan 12, 2019

Motivation for this change

root and root5 are broken on darwin. This applies the usual fix of adding cf-private to buildInputs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl veprbl added 6.topic: darwin Running or building packages on Darwin 11.by: package-maintainer labels Jan 12, 2019
@veprbl
Copy link
Member Author

veprbl commented Jan 12, 2019

@GrahamcOfBorg build root root5

@veprbl veprbl merged commit 73625f2 into NixOS:master Jan 12, 2019
@veprbl veprbl deleted the pr/root_darwin_fix branch December 1, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@veprbl @GrahamcOfBorg