Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode backport: 1.30.1 -> 1.30.2 #53824

Merged
merged 1 commit into from Jan 12, 2019
Merged

vscode backport: 1.30.1 -> 1.30.2 #53824

merged 1 commit into from Jan 12, 2019

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Jan 12, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
Copy link
Member

veprbl commented Jan 12, 2019

@GrahamcOfBorg build vscode vscode-with-extensions

@worldofpeace
Copy link
Contributor

@eadwu backport should be the commit cherry-picked from master.
So the other pr had to be merged first for that.

@eadwu
vscode: 1.30.1 -> 1.30.2
cffe29f 
(cherry picked from commit 6b80db3)
@eadwu
Copy link
Member Author

eadwu commented Jan 12, 2019

Rebased and fixed.

@flokli flokli merged commit 001b34a into NixOS:release-18.09 Jan 12, 2019
@flokli
Copy link
Contributor

flokli commented Jan 12, 2019

Thanks!

@eadwu eadwu deleted the backports/vscode-1.30.2 branch November 17, 2020 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eadwu @veprbl @worldofpeace @flokli @GrahamcOfBorg