Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DMD to provide libphobos2.so.x.y #53886

Merged
merged 1 commit into from Jan 21, 2019
Merged

DMD to provide libphobos2.so.x.y #53886

merged 1 commit into from Jan 21, 2019

Conversation

tex
Copy link
Contributor

@tex tex commented Jan 13, 2019 •
edited

Motivation for this change

Fixes #53885.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hedning
Copy link
Contributor

hedning commented Jan 13, 2019

cc maintainer @ThomasMader

@ThomasMader
Copy link
Contributor

I fixed the build of dub in release-18.09 with #53940.
As it is already fixed upstream in newer versions it's no issue on Master.

@tex For this reason please remove your fix for dub and just commit the fix for dmd to Master. It should find it's way to release-18.09 branch too I hope.

@tex tex changed the title DMD to provide libphobos2.so.x.y, fix DUB on !isDarwin DMD to provide libphobos2.so.x.y Jan 14, 2019
@tex
Copy link
Contributor Author

tex commented Jan 14, 2019 •
edited

Done. I live on master, and do not know how exactly versioning of NixOS works. Feel free to cherrypick to whatever branch you feel like.
When your fix to DUB installation gets into master? I see you put it on 18.xx branch...

@ThomasMader
Copy link
Contributor

Perfect, thanks.

I don't think you really use dub from master. dub on master is at version 1.13.0, it's the newest version and doesn't have the problem I fixed on release-18.09.
At this stable branch dub is at 1.10.0.

Cherry picking needs to be done by someone with commit rights as I don't have write permissions to the repository.

@GrahamcOfBorg build dmd

@tex
Copy link
Contributor Author

tex commented Jan 14, 2019 via email

@ThomasMader
Copy link
Contributor

Maybe you are at an old revision? Try updating to the newest revision.
dub 1.13.0 was being built on hydra: https://hydra.nixos.org/eval/1500084?filter=dub&compare=1500059&full=#tabs-still-succeed

That would not have been possible if the fix wasn't already incorporated into upstream. Here you see the commit which fixed it upstream: dlang/dub@2045a95

@tex
Copy link
Contributor Author

tex commented Jan 14, 2019

Interesting, I was on few days old master and there dub failed to build. Today's master builds dub with no troubles.

@tex
Copy link
Contributor Author

tex commented Jan 21, 2019

Is there anything else needed for merging this request?

@Mic92 Mic92 merged commit f9aa74f into NixOS:master Jan 21, 2019
@Mic92
Copy link
Member

Mic92 commented Jan 21, 2019

backport:

[detached HEAD f3b123e] DMD to provide libphobos2.so.x.y
Author: Milan Svoboda milan.svoboda@centrum.cz
Date: Sun Jan 13 18:26:01 2019 +0100
1 file changed, 1 insertion(+), 3 deletions(-)

@tex tex deleted the tex/dlang branch January 21, 2019 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tex @hedning @ThomasMader @Mic92 @GrahamcOfBorg