Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toml2nix: init at 0.1.1 #53883

Merged
merged 2 commits into from Jan 15, 2019
Merged

toml2nix: init at 0.1.1 #53883

merged 2 commits into from Jan 15, 2019

Conversation

P-E-Meunier
Copy link
Contributor

Motivation for this change

Toml2nix is a small tool to convert TOML files to Nix expressions. It will be particularly useful to solve the recurring portability problems of https://github.com/mozilla/nixpkgs-mozilla

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@P-E-Meunier P-E-Meunier mentioned this pull request Jan 13, 2019
Closed
@Mic92
Copy link
Member

Mic92 commented Jan 13, 2019

Btw. The next nix version will have a toml parser as a builtin: https://github.com/NixOS/nix/blob/master/src/libexpr/primops/fromTOML.cc

@dywedir
Copy link
Member

dywedir commented Jan 15, 2019

@GrahamcOfBorg build toml2nix

@dywedir dywedir merged commit 121318a into NixOS:master Jan 15, 2019
@Mic92
Copy link
Member

Mic92 commented Jan 21, 2019

There could a function in lib that uses either the fromToml builtin or fallback to this program.

@nbp
Copy link
Member

nbp commented Jan 21, 2019

@Mic92 not within Nixpkgs, as nixpkgs should not use the import-from-derivation pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dywedir dywedir dywedir left review comments

Assignees
No one assigned
Labels
6.topic: rust 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@P-E-Meunier @Mic92 @dywedir @nbp @GrahamcOfBorg