Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calibre: cssutils -> css-parser #53865

Merged
merged 2 commits into from Jan 14, 2019
Merged

calibre: cssutils -> css-parser #53865

merged 2 commits into from Jan 14, 2019

Conversation

jethrokuan
Copy link
Contributor

@jethrokuan jethrokuan commented Jan 13, 2019 •
edited

Motivation for this change

Updates an altered calibre dependency. Calibre now fails with:

ImportError: No module named css_parser.css

because of a recent change kovidgoyal/calibre@dd7d8ea

This also introduces a new package css-parser, which calibre uses.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

dotlambda
dotlambda requested changes Jan 13, 2019
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the python package should be a separate commit.

pkgs/development/python-modules/css-parser/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/css-parser/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/css-parser/default.nix Outdated Show resolved Hide resolved
@jethrokuan
Copy link
Contributor Author

Taking your reviews into account, but closing this PR to split it into 2.

@jethrokuan jethrokuan closed this Jan 13, 2019
@dotlambda
Copy link
Member

No need for two PRs, just two commits.

@dotlambda dotlambda reopened this Jan 13, 2019
@jethrokuan
Copy link
Contributor Author

done, thanks for reviewing again @dotlambda

@dotlambda dotlambda mentioned this pull request Jan 14, 2019
Closed
@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.css-parser python3.pkgs.css-parser

@dotlambda
Copy link
Member

@GrahamcOfBorg build calibre

@dotlambda dotlambda merged commit 05fda1f into NixOS:master Jan 14, 2019
@jethrokuan jethrokuan deleted the fix/calibre branch January 15, 2019 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jethrokuan @dotlambda @GrahamcOfBorg