Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghc844: update hash for d8495549ba9d194815c2d0eaee6797fc7c00756a patch #53810

Merged
merged 1 commit into from Jan 12, 2019

Conversation

lukateras
Copy link
Member

@lukateras lukateras commented Jan 11, 2019

Motivation for this change

Hash for one of GHC patches has changed, causing nix-shell -p pkgsCross.aarch64-multiplatform.ghc to fail with hash mismatch. Change doesn't seem to be malicious.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peti
Copy link
Member

peti commented Jan 12, 2019

Huh? How can the hash of a particular git commit ever change?

@vcunat
Copy link
Member

vcunat commented Jan 12, 2019

Possibly an imperfection in the normalization by fetchpatch. We might be able to improve it if we can identify it, though it's probably not worth it as long as it happens very rarely.

@peti
Copy link
Member

peti commented Jan 12, 2019

Oh, okay. I see.

@peti peti merged commit ae56467 into master Jan 12, 2019
@peti peti deleted the yegortimoshenko-patch-1 branch January 12, 2019 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants