Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.09] openssh: apply CVE-2018-20685 patch #53899

Merged
merged 1 commit into from Jan 13, 2019
Merged

[18.09] openssh: apply CVE-2018-20685 patch #53899

merged 1 commit into from Jan 13, 2019

Conversation

andir
Copy link
Member

@andir andir commented Jan 13, 2019

Motivation for this change

Backport of #53896

I had strip out the CVS headers of the patch file since on 18.09 we are using a slightly different version of OpenSSH.

/cc @samueldr @vcunat

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [÷] Tested via one or more NixOS test(s) if existing and applicable for the change (still running)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@andir
Copy link
Member Author

andir commented Jan 13, 2019

@GrahamcOfBorg build openssh openssh_hpn openssh_gssapi

@vcunat
Copy link
Member

vcunat commented Jan 13, 2019

Best rebuild this at once with the rest of staging-18.09.

@andir
openssh: apply CVE-2018-20685 patch
fb83c49 
And modified to remove the CVS headers

(cherry picked from commit 6d3a653)
@andir andir changed the base branch from release-18.09 to staging-18.09 January 13, 2019 21:53
@andir
Copy link
Member Author

andir commented Jan 13, 2019

Rebased onto staging-18.09

@GrahamcOfBorg build openssh openssh_hpn openssh_gssapi

vcunat
vcunat approved these changes Jan 13, 2019
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests succeeded for me locally (x86_64-linux) and on aarch64.nixos.community.

@vcunat vcunat merged commit fb83c49 into staging-18.09 Jan 13, 2019
@andir andir deleted the 18.09/openssh branch January 14, 2019 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andir @vcunat @GrahamcOfBorg