Add #6887: Highlight tiles within local authority of towns #7047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterN
reviewed
Jan 12, 2019
GabdaZM
force-pushed
the
boundary_cached
branch
from
7dbdd61
to
dc5eefb
Compare
GabdaZM
force-pushed
the
boundary_cached
branch
from
dc5eefb
to
142d12c
Compare
|
Now it uses a separate map array, not _m or _me. |
GabdaZM
force-pushed
the
boundary_cached
branch
from
142d12c
to
70924da
Compare
|
Should I break this down into two commits? One for introducing the map cache array, and a second for the town related modifications. |
Store cache data about map tiles. Does not get stored in save fiels.
… of towns Can be found at town information > local authority window Turn on/off for each town individually
GabdaZM
force-pushed
the
boundary_cached
branch
from
70924da
to
feaf434
Compare
nielsmh
added
the
wip
glx22
removed
the
wip
|
I think it can go to review. |
|
This pull request has been automatically marked as stale because it has not had any activity in the last month. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked version of Add #6887: Option to show zone inside local authority boundary of towns #7025
Caching the information on which tiles to highlight instead of calculating it on every redraw.
Currently using the first bit of _me.m8 to show a proof of concept, I can move it to a separate cache if this caching approach is better than the recalculating approach.